Closed Bug 730074 Opened 13 years ago Closed 13 years ago

XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces]

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: dholbert, Assigned: dholbert)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Filing bug on this gcc build warning: { XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces } From looking at other JSClass definitions, it looks like we should be using JSCLASS_NO_OPTIONAL_MEMBERS, which includes braces around its last contents (by way of JSCLASS_NO_INTERNAL_MEMBERS ) http://mxr.mozilla.org/mozilla-central/source/js/src/jsapi.h#3488
Attached patch fixSplinter Review
Attachment #600143 - Flags: review?(mrbkap)
Blocks: buildwarning
(In reply to Daniel Holbert [:dholbert] from comment #0) > From looking at other JSClass definitions, it looks like we should be using > JSCLASS_NO_OPTIONAL_MEMBERS For reference, here's another JSClass that uses this #define in place of all those NULLs: http://mxr.mozilla.org/mozilla-central/source/js/src/shell/js.cpp#4981 (many of the other JSClasses in that file do as well)
Attachment #600143 - Flags: review?(mrbkap) → review+
Keywords: checkin-needed
Assignee: general → dholbert
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: