Closed
Bug 730074
Opened 13 years ago
Closed 13 years ago
XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces]
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: dholbert, Assigned: dholbert)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
1022 bytes,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
Filing bug on this gcc build warning:
{
XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces
}
From looking at other JSClass definitions, it looks like we should be using JSCLASS_NO_OPTIONAL_MEMBERS, which includes braces around its last contents (by way of JSCLASS_NO_INTERNAL_MEMBERS )
http://mxr.mozilla.org/mozilla-central/source/js/src/jsapi.h#3488
Assignee | ||
Comment 1•13 years ago
|
||
Attachment #600143 -
Flags: review?(mrbkap)
Assignee | ||
Updated•13 years ago
|
Blocks: buildwarning
Assignee | ||
Comment 2•13 years ago
|
||
(In reply to Daniel Holbert [:dholbert] from comment #0)
> From looking at other JSClass definitions, it looks like we should be using
> JSCLASS_NO_OPTIONAL_MEMBERS
For reference, here's another JSClass that uses this #define in place of all those NULLs:
http://mxr.mozilla.org/mozilla-central/source/js/src/shell/js.cpp#4981
(many of the other JSClasses in that file do as well)
Updated•13 years ago
|
Attachment #600143 -
Flags: review?(mrbkap) → review+
Assignee | ||
Updated•13 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Assignee: general → dholbert
Comment 3•13 years ago
|
||
Keywords: checkin-needed
Target Milestone: --- → mozilla13
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•