XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces]

RESOLVED FIXED in mozilla13

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

(Blocks: 1 bug)

Trunk
mozilla13
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Filing bug on this gcc build warning:
{
XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces
}

From looking at other JSClass definitions, it looks like we should be using JSCLASS_NO_OPTIONAL_MEMBERS, which includes braces around its last contents (by way of JSCLASS_NO_INTERNAL_MEMBERS )
http://mxr.mozilla.org/mozilla-central/source/js/src/jsapi.h#3488
(Assignee)

Comment 1

7 years ago
Created attachment 600143 [details] [diff] [review]
fix
Attachment #600143 - Flags: review?(mrbkap)
(Assignee)

Updated

7 years ago
Blocks: 187528
(Assignee)

Comment 2

7 years ago
(In reply to Daniel Holbert [:dholbert] from comment #0)
> From looking at other JSClass definitions, it looks like we should be using
> JSCLASS_NO_OPTIONAL_MEMBERS

For reference, here's another JSClass that uses this #define in place of all those NULLs:
 http://mxr.mozilla.org/mozilla-central/source/js/src/shell/js.cpp#4981
(many of the other JSClasses in that file do as well)
Attachment #600143 - Flags: review?(mrbkap) → review+
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
Assignee: general → dholbert
https://hg.mozilla.org/integration/mozilla-inbound/rev/ade1f5c930d6
Keywords: checkin-needed
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/ade1f5c930d6
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.