730074 - XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces]

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Filing bug on this gcc build warning:
{
XrayWrapper.cpp:115:1: warning: missing braces around initializer for ‘void* [40]’ [-Wmissing-braces
}

From looking at other JSClass definitions, it looks like we should be using JSCLASS_NO_OPTIONAL_MEMBERS, which includes braces around its last contents (by way of JSCLASS_NO_INTERNAL_MEMBERS )
http://mxr.mozilla.org/mozilla-central/source/js/src/jsapi.h#3488

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to Daniel Holbert [:dholbert] from comment #0)
> From looking at other JSClass definitions, it looks like we should be using
> JSCLASS_NO_OPTIONAL_MEMBERS

For reference, here's another JSClass that uses this #define in place of all those NULLs:
 http://mxr.mozilla.org/mozilla-central/source/js/src/shell/js.cpp#4981
(many of the other JSClasses in that file do as well)

Comment 3

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ade1f5c930d6

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ade1f5c930d6