Closed
Bug 730163
Opened 13 years ago
Closed 13 years ago
Add telemetry for time spent waiting on cache service lock
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: u408661, Assigned: u408661)
References
Details
Attachments
(1 file, 2 obsolete files)
2.95 KB,
patch
|
u408661
:
review+
|
Details | Diff | Splinter Review |
This will help us determine how big of a problem the global lock actually is, and will also help us determine when we're making things better and by how much.
I'm not tied to having 2 different telemetry entries for main thread vs. non-main thread, but I thought it might be useful to know how long we block the main thread vs other stuff on the cache thread.
Attachment #601049 -
Flags: review?(michal.novotny)
Comment 2•13 years ago
|
||
Nick, why not to add the telemetry right inside nsCacheService::Lock() ?
Comment on attachment 601049 [details] [diff] [review]
patch
Honza, I have no good reason, and looking at the code, I realized there's at least one place outside the autolock where we do actually call nsCacheService::Lock directly, so in there is probably a better place to put the telemetry. I'll update the patch.
Attachment #601049 -
Flags: review?(michal.novotny)
OK, here's the same patch with the telemetry accumulation pushed down into nsCacheService::Lock as Honza suggested.
Attachment #601049 -
Attachment is obsolete: true
Attachment #601066 -
Flags: review?(michal.novotny)
Updated•13 years ago
|
Attachment #601066 -
Flags: review?(michal.novotny) → review+
Update commit message w/r=michal. carry forward r+
Attachment #601066 -
Attachment is obsolete: true
Attachment #601361 -
Flags: review+
Keywords: checkin-needed
Comment 7•13 years ago
|
||
Keywords: checkin-needed
Comment 8•13 years ago
|
||
I believe the times will be about a millisecond if even that long. I observed long times waiting only short after start when the cache warms up.
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•