730189 - Bluetooth tethering not considered a valid Internet connection by "Set Up Sync"

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Android Sync, defect, P2)

Description

[ravi_n+mozilla]

User Agent: Mozilla/5.0 (Android; Tablet; rv:12.0a2) Gecko/12.0a2 Firefox/12.0a2
Build ID: 20120223042013

Steps to reproduce:

I tried to set up Firefox Sync on my ASUS Transformer (running ICS) while tethered to my phone via Bluetooth.


Actual results:

Set Up Sync said I didn't have an Internet connection (even though I am using that connection to file this bug).


Expected results:

I should have been able to set up Firefox Sync just as if I had been connected via WiFi.

Comment 1

[Aaron Train [:aaronmt]]

Are you able to create any other Android accounts and sync while tethered? Have you also tried Nightly (http://nightly.mozilla.org) for Android?

Comment 2

[Richard Newman [:rnewman]]

Good catch. We only check for wifi and mobile as data connections.

We should probably be checking for <http://developer.android.com/reference/android/net/ConnectivityManager.html#EXTRA_NO_CONNECTIVITY> instead.

Comment 3

[ravi_n+mozilla]

(In reply to Aaron Train [:aaronmt] from comment #1)
> Are you able to create any other Android accounts and sync while tethered?
> Have you also tried Nightly (http://nightly.mozilla.org) for Android?

1. Yes. I was rebuilding my Transformer from scratch after the ICS update and I successfully added and synced my Google account while tethered over Bluetooth.

2. I just downloaded Nightly and I have the same problem there.

Comment 4

[ravi_n+mozilla]

(In reply to Richard Newman [:rnewman] from comment #2)
> Good catch. We only check for wifi and mobile as data connections.
> 
> We should probably be checking for
> <http://developer.android.com/reference/android/net/ConnectivityManager.
> html#EXTRA_NO_CONNECTIVITY> instead.

Thanks. I only caught it because the ICS ROM I'm running on my phone doesn't support WiFi tethering, which made me switch to Bluetooth. Along those lines, I wonder what would happen if someone got a device (probably a tablet, I'd guess) online with a USB Ethernet adapter.

Comment 5

[Richard Newman [:rnewman]]

We will also fail to spot WiMax, Ethernet, and dial-up… unless you _also_ have wifi or GPRS/EDGE/3G, of course.

Comment 6

[Marco Bonardo [:mak]]

this changeset has been assigned to this bug, though this bug doesn't even have an attached patch. So whoever knows what's up please fix it.

https://hg.mozilla.org/mozilla-central/rev/d9460c5f6415

Comment 7

[Richard Newman [:rnewman]]

mak: Android Sync development takes place on GitHub, and changes are landed directly on inbound after being reviewed and merged upstream. When you're sheriffing, you won't see patch attachments.

Thanks for checking!

Comment 8

[Tracy Walker [:tracy]]

ravi, please verify this against a nighty build. thanks.

Comment 9

[Cristian Nicolae (:xti)]

Android Sync is working as expected if the Internet connection is set via Bluetooth tethering. Closing bug as verified fixed on:

Firefox 15.0a1 (2012-05-29)
Firefox 14.0a2 (2012-05-29)

Device: Galaxy Nexus
OS: Android 4.0.2