Closed Bug 730195 Opened 13 years ago Closed 13 years ago

backport fixes to mozilla-esr10 branch to make leak test builds work

Categories

(Release Engineering :: General, defect)

Product:
Release Engineering
Component:
General
Platform:
x86_64
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox-esr1011+ fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
firefox-esr10 11+ fixed

People

(Reporter: philor, Assigned: espindola)

References

Details

(Keywords: regression, Whiteboard: [qa-])

Attachments

(2 files, 2 obsolete files)

New with the missing include
15.85 KB, patch
lsblakk
: approval-mozilla-esr10+
Details | Diff | Splinter Review
missing bits
1.30 KB, patch
glandium
: review+
akeybl
: approval-mozilla-esr10+
Details | Diff | Splinter Review
Attached patch like so? (obsolete) — — Splinter Review
Pretty sure this probably works, I think, maybe. I copy-pasted it carefully :)
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #600307 - Flags: review?(bhearsum)
Comment on attachment 600307 [details] [diff] [review] like so? Sigh.
Attachment #600307 - Attachment is obsolete: true
Attachment #600307 - Flags: review?(bhearsum)
Apparently what I actually meant to file was "please quickly back out attachment 599177 [details] [diff] [review] from bug 698827 comment 28 and reconfig for the backout, because neither thing that it did actually works."
Assignee: philringnalda → armenzg
Summary: esr10 shouldn't be doing leak tests on 10.6 → esr10 shouldn't be doing leak tests on 10.6 or 10.5 debug builds on 10.6, because they both still time out
To complete the doesn't work, https://tbpl.mozilla.org/php/getParsedLog.php?id=9586777&tree=Mozilla-Esr10 is a 10.5 debug build built on 10.6 also timing out.
Blocks: 698827
Keywords: regression
Should we backport the missing fixes or move the builds?
We should backport the fixes. Debug builds have been a requirement of all stable branches in the past, and I don't see any reason to change that now...
Thanks for looking at this Rafael.
Summary: esr10 shouldn't be doing leak tests on 10.6 or 10.5 debug builds on 10.6, because they both still time out → backport fixes to mozilla-esr10 branch to make leak test builds work
tracking-firefox-esr10: --- → ?
Summary: backport fixes to mozilla-esr10 branch to make leak test builds work → esr10 shouldn't be doing leak tests on 10.6 or 10.5 debug builds on 10.6, because they both still time out
Summary: esr10 shouldn't be doing leak tests on 10.6 or 10.5 debug builds on 10.6, because they both still time out → backport fixes to mozilla-esr10 branch to make leak test builds work
Once we've confirmed the fix, feel free to land on mozilla-esr10. For more info see https://wiki.mozilla.org/Release_Management/ESR_Landing_Process
tracking-firefox-esr10: ? → 11+
https://tbpl.mozilla.org/?tree=Mozilla-Esr10&rev=0d28a290b853
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment on attachment 600375 [details] [diff] [review] New with the missing include [Triage comment] This patch is being tracked for the upcoming esr 10.0.3 release and needs to be landed today preferably, or tomorrow if need be. Let me know if there are any concerns about getting it landed in time. See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for details.
Attachment #600375 - Flags: approval-mozilla-esr10+
> [Triage comment] > This patch is being tracked for the upcoming esr 10.0.3 release and needs to > be landed today preferably, or tomorrow if need be. Let me know if there > are any concerns about getting it landed in time. See > https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for details. Where do I need to land it? It is already in https://tbpl.mozilla.org/?tree=Mozilla-Esr10&rev=0d28a290b853
> Where do I need to land it? It is already in > > https://tbpl.mozilla.org/?tree=Mozilla-Esr10&rev=0d28a290b853 So sorry, my mistake for not noticing comment 13 - we're good here, thank you Rafael
Whiteboard: [qa-]
FWIW, this broke linux arm because _URC_NORMAL_STOP is not defined there. Note other branches use_URC_FOREIGN_EXCEPTION_CAUGHT.
Attached patch missing bits — — Splinter Review
I now see that I backported the commit that showed up when m-i was merged to m-c, but unfortunately that missed the android build fix. Attached is the fix that went into m-c. I produced it with git diff c9a74f233918cd3fa38789cfd64861d8f75b8c3c a40b5fd544bbb71cb9f5a9649aafdffa6a5bd655 xpcom/ with doublec's repo. Do you think we should backport it to esr?
Attachment #607563 - Flags: review?(mh+mozilla)
(In reply to Rafael Ávila de Espíndola (:espindola) from comment #18) > Do you think we should backport it to esr? I think we should.
Attachment #607563 - Flags: review?(mh+mozilla) → review+
Comment on attachment 607563 [details] [diff] [review] missing bits akeybl, ok with you too?
Attachment #607563 - Flags: approval-mozilla-esr10?
Comment on attachment 607563 [details] [diff] [review] missing bits [Triage Comment] Approved for the ESR in support of running leak builds on 10.6 machines instead of 10.5.
Attachment #607563 - Flags: approval-mozilla-esr10? → approval-mozilla-esr10+
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: