Last Comment Bug 730213 - Port |Bug 698381 - Node.cloneNode's deep parameter should be optional (default to true)| to comm-central
: Port |Bug 698381 - Node.cloneNode's deep parameter should be optional (defaul...
Status: VERIFIED FIXED
:
Product: MailNews Core
Classification: Components
Component: Import (show other bugs)
: Trunk
: All All
: P1 blocker (vote)
: Thunderbird 13.0
Assigned To: Serge Gautherie (:sgautherie)
:
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on: 698381
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-23 23:26 PST by Serge Gautherie (:sgautherie)
Modified: 2012-02-24 01:40 PST (History)
3 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
(Av1) Add new 'aOptionalArgc' parameter to CloneNode() [Checked in: Comment 2] (1.69 KB, patch)
2012-02-23 23:50 PST, Serge Gautherie (:sgautherie)
standard8: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2012-02-23 23:26:43 PST
http://tinderbox.mozilla.org/showlog.cgi?log=ThunderbirdTrunk/1330051258.1330056057.10491.gz
WINNT 5.2 comm-central leak test build on 2012/02/23 18:40:58
{
nsEudoraEditor.cpp

e:/buildbot/win32-comm-central-bloat/build/mailnews/import/eudora/src/nsEudoraEditor.cpp(468) : error C2511: 'nsresult nsEudoraHTMLImageElement::CloneNode(bool,nsIDOMNode **)' : overloaded member function not found in 'nsEudoraHTMLImageElement'

        e:\buildbot\win32-comm-central-bloat\build\mailnews\import\eudora\src\nsEudoraEditor.h(65) : see declaration of 'nsEudoraHTMLImageElement'
}
Comment 1 Serge Gautherie (:sgautherie) 2012-02-23 23:37:42 PST
Most likely caused by bug 698381.
Comment 2 Serge Gautherie (:sgautherie) 2012-02-23 23:50:52 PST
Created attachment 600324 [details] [diff] [review]
(Av1) Add new 'aOptionalArgc' parameter to CloneNode()
[Checked in: Comment 2]

Asking for post-push review of
http://hg.mozilla.org/comm-central/rev/614ca8370fac
Comment 4 Mark Banner (:standard8, limited time in Dec) 2012-02-24 01:40:09 PST
Comment on attachment 600324 [details] [diff] [review]
(Av1) Add new 'aOptionalArgc' parameter to CloneNode()
[Checked in: Comment 2]

Thanks for fixing the bustage :-)

Note You need to log in before you can comment on or make changes to this bug.