When using dummy PBuffers, don't require any specific formats

RESOLVED FIXED in mozilla15

Status

()

Core
Canvas: WebGL
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: jgilbert, Assigned: jgilbert)

Tracking

unspecified
mozilla15
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 3 obsolete attachments)

(Assignee)

Description

6 years ago
Right now, even when we're just creating a dummy 16x16 PBuffer, we try to get the pixel formats we need, even though we never use them. This is causing us to fail in cases with more minimal functionality.

Also we should follow-up and fix the problems with creating fairly minimal PBuffers.
(Assignee)

Comment 1

6 years ago
Created attachment 600500 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit
Assignee: nobody → jgilbert
Status: NEW → ASSIGNED
Attachment #600500 - Flags: review?(bjacob)
Attachment #600500 - Flags: feedback?(romaxa)
Attachment #600500 - Flags: review?(bjacob) → review+
(Assignee)

Comment 2

6 years ago
Created attachment 600545 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit
Attachment #600500 - Attachment is obsolete: true
Attachment #600545 - Flags: feedback?(romaxa)
Attachment #600500 - Flags: feedback?(romaxa)
(Assignee)

Comment 3

6 years ago
Created attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Forgot to hg qrefresh. ><
Attachment #600545 - Attachment is obsolete: true
Attachment #600550 - Flags: feedback?(romaxa)
Attachment #600545 - Flags: feedback?(romaxa)
Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

This is much better, at least for initialization (still did not get it rendered properly, but it seems different problem)
Attachment #600550 - Flags: feedback?(romaxa) → feedback+
Any plans to land it?
Created attachment 613723 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Updated to latest m-c
(Assignee)

Comment 7

5 years ago
Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Review of attachment 600550 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but let's wait until moz-central stops being fennec-aurora.
Attachment #600550 - Flags: review+
Created attachment 617335 [details] [diff] [review]
To Push, updated to latest m-c tip
Attachment #613723 - Attachment is obsolete: true
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf14930d495e
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/cf14930d495e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.