Last Comment Bug 730417 - When using dummy PBuffers, don't require any specific formats
: When using dummy PBuffers, don't require any specific formats
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Canvas: WebGL (show other bugs)
: unspecified
: x86_64 Windows 7
: -- normal (vote)
: mozilla15
Assigned To: Jeff Gilbert [:jgilbert]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-24 12:27 PST by Jeff Gilbert [:jgilbert]
Modified: 2012-04-25 07:30 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Add case for minimal PBuffer requests and always request PBuffer bit (3.49 KB, patch)
2012-02-24 13:31 PST, Jeff Gilbert [:jgilbert]
jacob.benoit.1: review+
Details | Diff | Splinter Review
Add case for minimal PBuffer requests and always request PBuffer bit (3.49 KB, patch)
2012-02-24 15:19 PST, Jeff Gilbert [:jgilbert]
no flags Details | Diff | Splinter Review
Add case for minimal PBuffer requests and always request PBuffer bit (4.36 KB, patch)
2012-02-24 15:28 PST, Jeff Gilbert [:jgilbert]
jgilbert: review+
romaxa: feedback+
Details | Diff | Splinter Review
Add case for minimal PBuffer requests and always request PBuffer bit (3.51 KB, patch)
2012-04-10 12:49 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review
To Push, updated to latest m-c tip (3.50 KB, patch)
2012-04-22 12:11 PDT, Oleg Romashin (:romaxa)
no flags Details | Diff | Splinter Review

Description Jeff Gilbert [:jgilbert] 2012-02-24 12:27:31 PST
Right now, even when we're just creating a dummy 16x16 PBuffer, we try to get the pixel formats we need, even though we never use them. This is causing us to fail in cases with more minimal functionality.

Also we should follow-up and fix the problems with creating fairly minimal PBuffers.
Comment 1 Jeff Gilbert [:jgilbert] 2012-02-24 13:31:58 PST
Created attachment 600500 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit
Comment 2 Jeff Gilbert [:jgilbert] 2012-02-24 15:19:18 PST
Created attachment 600545 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit
Comment 3 Jeff Gilbert [:jgilbert] 2012-02-24 15:28:43 PST
Created attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Forgot to hg qrefresh. ><
Comment 4 Oleg Romashin (:romaxa) 2012-02-24 17:08:20 PST
Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

This is much better, at least for initialization (still did not get it rendered properly, but it seems different problem)
Comment 5 Oleg Romashin (:romaxa) 2012-03-08 09:29:39 PST
Any plans to land it?
Comment 6 Oleg Romashin (:romaxa) 2012-04-10 12:49:03 PDT
Created attachment 613723 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Updated to latest m-c
Comment 7 Jeff Gilbert [:jgilbert] 2012-04-20 11:33:40 PDT
Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Review of attachment 600550 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but let's wait until moz-central stops being fennec-aurora.
Comment 8 Oleg Romashin (:romaxa) 2012-04-22 12:11:38 PDT
Created attachment 617335 [details] [diff] [review]
To Push, updated to latest m-c tip
Comment 9 Ryan VanderMeulen [:RyanVM] 2012-04-24 17:02:00 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf14930d495e

Note You need to log in before you can comment on or make changes to this bug.