730417 - When using dummy PBuffers, don't require any specific formats

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Right now, even when we're just creating a dummy 16x16 PBuffer, we try to get the pixel formats we need, even though we never use them. This is causing us to fail in cases with more minimal functionality.

Also we should follow-up and fix the problems with creating fairly minimal PBuffers.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Add case for minimal PBuffer requests and always request PBuffer bit

Comment 2

[Kelsey Gilbert [:jgilbert]]

Attachment: Add case for minimal PBuffer requests and always request PBuffer bit

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: Add case for minimal PBuffer requests and always request PBuffer bit

Forgot to hg qrefresh. ><

Comment 4

[Oleg Romashin (:romaxa)]

Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

This is much better, at least for initialization (still did not get it rendered properly, but it seems different problem)

Comment 5

[Oleg Romashin (:romaxa)]

Any plans to land it?

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Add case for minimal PBuffer requests and always request PBuffer bit

Updated to latest m-c

Comment 7

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Review of attachment 600550 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but let's wait until moz-central stops being fennec-aurora.

Comment 8

[Oleg Romashin (:romaxa)]

Attachment: To Push, updated to latest m-c tip

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf14930d495e

Comment 10

[(no longer active)]

https://hg.mozilla.org/mozilla-central/rev/cf14930d495e