Closed Bug 730417 Opened 10 years ago Closed 9 years ago

When using dummy PBuffers, don't require any specific formats

Categories

(Core :: Canvas: WebGL, defect)

x86_64
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla15

People

(Reporter: jgilbert, Assigned: jgilbert)

Details

Attachments

(2 files, 3 obsolete files)

Right now, even when we're just creating a dummy 16x16 PBuffer, we try to get the pixel formats we need, even though we never use them. This is causing us to fail in cases with more minimal functionality.

Also we should follow-up and fix the problems with creating fairly minimal PBuffers.
Assignee: nobody → jgilbert
Status: NEW → ASSIGNED
Attachment #600500 - Flags: review?(bjacob)
Attachment #600500 - Flags: feedback?(romaxa)
Attachment #600500 - Flags: review?(bjacob) → review+
Attachment #600500 - Attachment is obsolete: true
Attachment #600545 - Flags: feedback?(romaxa)
Attachment #600500 - Flags: feedback?(romaxa)
Forgot to hg qrefresh. ><
Attachment #600545 - Attachment is obsolete: true
Attachment #600550 - Flags: feedback?(romaxa)
Attachment #600545 - Flags: feedback?(romaxa)
Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

This is much better, at least for initialization (still did not get it rendered properly, but it seems different problem)
Attachment #600550 - Flags: feedback?(romaxa) → feedback+
Any plans to land it?
Comment on attachment 600550 [details] [diff] [review]
Add case for minimal PBuffer requests and always request PBuffer bit

Review of attachment 600550 [details] [diff] [review]:
-----------------------------------------------------------------

R+, but let's wait until moz-central stops being fennec-aurora.
Attachment #600550 - Flags: review+
Attachment #613723 - Attachment is obsolete: true
https://hg.mozilla.org/integration/mozilla-inbound/rev/cf14930d495e
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla15
https://hg.mozilla.org/mozilla-central/rev/cf14930d495e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.