730418 - Search button should not open new tab

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Description

[Brian Nicholson (:bnicholson)]

Searching from the search button on a phone opens the page in a new tab. This can result in many accumulated tabs for users who prefer the search button over clicking the URL bar. We didn't open a new tab in XUL Fennec when using the search button, and we also don't open a new tab on Desktop when we search from the search bar, so we should probably just search using the existing tab.

Comment 1

[Doug Turner (:dougt)]

ian, what say you?

Comment 2

[Ian Barlow (:ibarlow)]

I agree here, we shouldn't be popping a new tab open for each search, unless you explicitly open a new tab before doing a search by going tabs > new tab.

Comment 3

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 603104 [details] [diff] [review]
patch

Review of attachment 603104 [details] [diff] [review]:
-----------------------------------------------------------------

Could you please remove onEditRequested(). Both of them are doing the same operation.
r+ with that change.

Comment 5

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/317d3d5ca142