Open Bug 730498 Opened 12 years ago Updated 1 year ago

##!!! ASSERTION: nsCOMArrayEnumerator not thread-safe: '_mOwningThread.GetThread() == PR_GetCurrentThread()', file mozilla/xpcom/build/nsArrayEnumerator.cpp, line 161


(MailNews Core :: Import, defect)



(Not tracked)


(Reporter: hiro, Unassigned)



(Whiteboard: [patchlove])


(1 file)

The test in bug 700920 comment #3 causes this assertion.
We need to fix this.
Blocks: 700920
Attached patch Proposed fixSplinter Review
nsISupportsArray which is an array of nsIImportMailboxDescriptor is generated in importing thread, so we don't have to dispatch to the main thread.
Attachment #600569 - Flags: review?(dbienvenu)
Comment on attachment 600569 [details] [diff] [review]
Proposed fix

the problem is that these classes really aren't thread-safe, so making the isupports thread-safe isn't sufficient, other than to quiet the warnings which are really legitimate warnings.

Fixing the thread-safety assertions might well involve rewriting the import code not to run on its own thread. Fixing this particular assertion probably involves figuring out a way of getting a thread-safe array or enumerator out of the mailnews backend.
Attachment #600569 - Flags: review?(dbienvenu) → review-
comment 2 is currently our basic problem with import
Whiteboard: [patchlove]
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.