Content-Disposition: quoted-string in RFC2231-continuations not handled

RESOLVED FIXED in mozilla15


7 years ago
3 years ago


(Reporter: julian.reschke, Assigned: julian.reschke)


(Blocks: 1 bug)


Firefox Tracking Flags

(Not tracked)




(1 attachment, 1 obsolete attachment)



7 years ago
When processing continuation parameters using RFC2231 encoding, backslash-escapes in quoted-string values are not processed.

See test case at

This is similar to bug 588389, which however wasn't about continuation parameters, and didn't fix these.

Comment 1

7 years ago
Created attachment 622106 [details] [diff] [review]
Proposed patch, incl test case

try results:
Attachment #622106 - Flags: review?(jduell.mcbugs)

Comment 2

7 years ago
Comment on attachment 622106 [details] [diff] [review]
Proposed patch, incl test case

Review of attachment 622106 [details] [diff] [review]:

+r with nits fixed.

::: netwerk/mime/nsMIMEHeaderParamImpl.cpp
@@ +271,1 @@

no space between cont and (

::: netwerk/test/unit/test_MIME_params.js
@@ +394,5 @@
> +  // unmatched escape char
> +  ["attachment; filename=basic; filename*0=\"foo\"; filename*1=\"\\b\\a\\", 
> +   "attachment", "fooba\\",
> +   "attachment", "basic"],
> +

These would be easier to read if you just make the overall strings single-quoted, so you don't have to escape double quotes in them.
Attachment #622106 - Flags: review?(jduell.mcbugs) → review+

Comment 3

7 years ago
Thanks for the feedback; will update in time for FF16 :-)

Comment 4

7 years ago
Created attachment 627672 [details] [diff] [review]
Proposed patch, incl test case

Did the syntactical fixes. Try result at Propose to checkin for -16.
Attachment #622106 - Attachment is obsolete: true
Attachment #627672 - Flags: review?(jduell.mcbugs)

Comment 5

7 years ago
Comment on attachment 627672 [details] [diff] [review]
Proposed patch, incl test case
Attachment #627672 - Flags: review?(jduell.mcbugs) → review+
Please can you set assignee and milestone when landing - thanks :-)
Assignee: nobody → julian.reschke
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.