Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Content-Disposition: quoted-string in RFC2231-continuations not handled

RESOLVED FIXED in mozilla15

Status

Core Graveyard
File Handling
RESOLVED FIXED
6 years ago
a year ago

People

(Reporter: Julian Reschke, Assigned: Julian Reschke)

Tracking

(Blocks: 1 bug)

Trunk
mozilla15

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
When processing continuation parameters using RFC2231 encoding, backslash-escapes in quoted-string values are not processed.

See test case at http://greenbytes.de/tech/tc2231/#attfncontqs

This is similar to bug 588389, which however wasn't about continuation parameters, and didn't fix these.
(Assignee)

Comment 1

5 years ago
Created attachment 622106 [details] [diff] [review]
Proposed patch, incl test case

try results: https://tbpl.mozilla.org/?tree=Try&rev=2fec6a7618fe
Attachment #622106 - Flags: review?(jduell.mcbugs)
Comment on attachment 622106 [details] [diff] [review]
Proposed patch, incl test case

Review of attachment 622106 [details] [diff] [review]:
-----------------------------------------------------------------

+r with nits fixed.

::: netwerk/mime/nsMIMEHeaderParamImpl.cpp
@@ +271,1 @@
>  

no space between cont and (

::: netwerk/test/unit/test_MIME_params.js
@@ +394,5 @@
> +  // unmatched escape char
> +  ["attachment; filename=basic; filename*0=\"foo\"; filename*1=\"\\b\\a\\", 
> +   "attachment", "fooba\\",
> +   "attachment", "basic"],
> +

These would be easier to read if you just make the overall strings single-quoted, so you don't have to escape double quotes in them.
Attachment #622106 - Flags: review?(jduell.mcbugs) → review+
(Assignee)

Comment 3

5 years ago
Thanks for the feedback; will update in time for FF16 :-)
(Assignee)

Comment 4

5 years ago
Created attachment 627672 [details] [diff] [review]
Proposed patch, incl test case

Did the syntactical fixes. Try result at https://tbpl.mozilla.org/?tree=Try&rev=27898d8ca156. Propose to checkin for -16.
Attachment #622106 - Attachment is obsolete: true
Attachment #627672 - Flags: review?(jduell.mcbugs)
Comment on attachment 627672 [details] [diff] [review]
Proposed patch, incl test case

https://hg.mozilla.org/integration/mozilla-inbound/rev/75a9a7debdb0
Attachment #627672 - Flags: review?(jduell.mcbugs) → review+

Comment 6

5 years ago
Please can you set assignee and milestone when landing - thanks :-)

https://hg.mozilla.org/mozilla-central/rev/75a9a7debdb0
Assignee: nobody → julian.reschke
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla15
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.