Closed Bug 730596 Opened 8 years ago Closed 8 years ago

Make the HTML Panel context menu more generic (should work even if the HTML Panel is closed)

Categories

(DevTools :: Inspector, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 13

People

(Reporter: paul, Unassigned)

References

Details

Attachments

(1 file)

No description provided.
Attached patch patch 1Splinter Review
easier than I thought :)
Attachment #600695 - Flags: review?(dcamp)
Comment on attachment 600695 [details] [diff] [review]
patch 1

what happens if the tree panel isn't open?

We probably need a more generic method than the one in treePanel (deleteChildBox).
(In reply to Rob Campbell [:rc] (robcee) from comment #2)
> Comment on attachment 600695 [details] [diff] [review]
> patch 1
> 
> what happens if the tree panel isn't open?
> 
> We probably need a more generic method than the one in treePanel
> (deleteChildBox).

Not sure to understand.

The deleteNode function does 2 things:
1) delete the node from the document.
2) delete the node from the tree panel.

If deleteNode is called if the tree panel is closed, there's no reason to delete the node from the tree panel.
ok, my bad. Carry on. :)
Attachment #600695 - Flags: review?(dcamp)
Whiteboard: [land-in-fx-team]
https://hg.mozilla.org/integration/fx-team/rev/fe97799112ed
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/fe97799112ed
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Hardware: x86 → All
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 13
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.