730596 - Make the HTML Panel context menu more generic (should work even if the HTML Panel is closed)

Status: RESOLVED FIXED

(DevTools :: Inspector, defect)

Comment 1

[Paul Rouget [:paul]]

Attachment: patch 1

easier than I thought :)

Comment 2

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 600695 [details] [diff] [review]
patch 1

what happens if the tree panel isn't open?

We probably need a more generic method than the one in treePanel (deleteChildBox).

Comment 3

[Paul Rouget [:paul]]

(In reply to Rob Campbell [:rc] (robcee) from comment #2)
> Comment on attachment 600695 [details] [diff] [review]
> patch 1
> 
> what happens if the tree panel isn't open?
> 
> We probably need a more generic method than the one in treePanel
> (deleteChildBox).

Not sure to understand.

The deleteNode function does 2 things:
1) delete the node from the document.
2) delete the node from the tree panel.

If deleteNode is called if the tree panel is closed, there's no reason to delete the node from the tree panel.

Comment 4

[Rob Campbell [:rc] (:robcee)]

ok, my bad. Carry on. :)

Comment 5

[Rob Campbell [:rc] (:robcee)]

https://hg.mozilla.org/integration/fx-team/rev/fe97799112ed

Comment 6

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/fe97799112ed