730676 - Add CallArgs::hasDefined convenience method

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jason Orendorff [:jorendorff]]

See bug 726223 comment 5.

Comment 1

[Jason Orendorff [:jorendorff]]

Attachment: v1

Comment 2

[Luke Wagner [:luke]]

Comment on attachment 600771 [details] [diff] [review]
v1

Review of attachment 600771 [details] [diff] [review]:
-----------------------------------------------------------------

Great

::: js/src/builtin/RegExp.cpp
@@ +344,5 @@
>           * See ECMAv5 15.10.3.1.
>           */
> +        if (args.length() >= 1 &&
> +            IsObjectWithClass(args[0], ESClass_RegExp, cx) &&
> +            !args.hasDefined(1))

How about
  args.hasDefined(0) &&
  IsObjectWithClass(args[0], ESClass_RegExp, cx) &&
  !args.hasDefined(1)
?  (Unnecessary 'undefined' test, but I think this shouldn't be significant here.)

::: js/src/jsobj.cpp
@@ +2400,3 @@
>      if (!obj)
> +        return false;
> +    args.rval().setObject(*obj); /* Root and prepare for eventual return. */

Pre-existing, but args.rval() should only be assigned to after the last observable operation.

Comment 3

[Jason Orendorff [:jorendorff]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3b6ef7305164

Comment 4

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/3b6ef7305164