730685 - Unused entities in lightning.dtd

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Merike Sell (:merike)]

lightning.calendarproperties.showevents.inagenda.label and lightning.calendarproperties.showtasks.label seem to be unused: http://mxr.mozilla.org/comm-central/search?string=lightning.calendarproperties.show

Comment 1

[Stefan Sitter [:ssitter]]

They were added as a first part of Bug 431039, still waiting for final completion.

Comment 2

[Stefan Sitter [:ssitter]]

Got the wrong bug number. They were added as a first part of Bug 412800, still waiting for final completion.

Comment 3

[Merike Sell (:merike)]

Attachment: fix

Comment 4

[Merike Sell (:merike)]

Oh, forgot to check old history here and also didn't refresh the bug meanwhile. So, I guess this qualifies as invalid then?

Comment 5

[Philipp Kewisch [:Fallen][📱📆]]

Comment on attachment 600801 [details] [diff] [review]
fix

Given that bug doesn't look like it will get any traction soon (too bad), I'd be fine with removing the strings for now. I'll leave it up to you.

Comment 6

[Merike Sell (:merike)]

Looking at it from localizer viewpoint I'm inclined towards removing unused strings. These possibly confuse both new and long-time localizers.

I only noticed them because they appeared in a localization update diff (due to some strings moved around in close context) that's publicly posted to a google group and someone asked whether they shouldn't be translated into a different form (Estonian differentiates between direct commands and option descriptions more clearly than English).

Comment 7

[(Out Sep 17-23) Ryan VanderMeulen]

http://hg.mozilla.org/comm-central/rev/ef7d32dbdb47