730720 - Crash Reporter -> User Comments: don't remove line breaks

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[MrX1980]

The "Mozilla Crash Reporter" has a textfield for comments where users can use line breaks. But in Socorro -> "User Comments" these line breaks are missing. The text is in one single line. So sometimes it is not easy to read comments.
In my example you can see "Launch Experiment" but it don't belongs to the url.
But it is visible in one line and can be misunderstood that is should be belong to the url.

Now:
User Comments = http://www.chromeexperiments.com/detail/fireworks/?f= Launch Experiment

Should be:
User Comments = http://www.chromeexperiments.com/detail/fireworks/?f=
Launch Experiment

Example:
https://crash-stats.mozilla.com/report/index/bp-7fad7caa-62d1-4539-9a95-151ce2120226

Comment 1

[Peter Bengtsson [:peterbe]]

When we show comments on the report list page we definitely preserve the line breaks.
https://github.com/mozilla/socorro/blob/d643d63f35282346e88127d40d93ae4664af541e/webapp-django/crashstats/crashstats/templates/crashstats/report_list.html#L183

Comment 2

[MrX1980]

https://crash-stats.mozilla.com/report/index/58438e2c-10a6-4823-bdf4-1cb552130906

User Comments: Test because of bug 730720 Line1 Line2 Line3

Comment 3

[Peter Bengtsson [:peterbe]]

Attachment: Screen Shot 2013-09-06 at 11.59.23 AM.png

A ha! I see. 

One thing I'm royally confused about is why does that just show one comment and clicking the Comments tab show all 7 tabs.

Comment 4

[Peter Bengtsson [:peterbe]]

Kairo,
Why does the reportindex have multiple comments? I.e. a Comments tab. Surely one crash just has one comment.

Comment 5

[Peter Bengtsson [:peterbe]]

Pull request: https://github.com/mozilla/socorro/pull/1478

It's still a bit of a mystery to me why we have comments by signature on the report index page.

Comment 6

[Robert Kaiser]

reports/index should not have a "Comments" tab, I think, that should be on reports/list only.

Still, the Comments tab shows stuff correctly, the actual field list on the Details tab doesn't.

Comment 7

[Peter Bengtsson [:peterbe]]

I'd be happy to remove the Comments tab from reportindex as of this patch. You ok with that Kairo?

Comment 8

[Robert Kaiser]

(In reply to Peter Bengtsson [:peterbe] from comment #7)
> I'd be happy to remove the Comments tab from reportindex as of this patch.
> You ok with that Kairo?

Yes, that tab is confusing there, and we link to "More Reports" anyhow where people can get a less confusing "Comments" tab.

Comment 9

[Peter Bengtsson [:peterbe]]

Pull request: https://github.com/mozilla/socorro/pull/1478

Comment 10

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/015abeb466adafbe6c2fcf5ff7351d318f83b15f
fixes bug 730720 - Crash Reporter -> User Comments: don't remove line breaks, r=lonnen

Comment 11

[Matt Brandt [:mbrandt]]

Attachment: qa - verified on stage

QA verified on stage:
- comments tab removed from /report/index in both the admin & non-admin views
- comments contain the proper line breaks (https://crash-stats.allizom.org/report/index/5715203a-d441-4fff-aa34-4b1aa2130908)