730749 - GeckoProfile relies on API version 8+ methods

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/file/default/mobile/android/base/GeckoProfile.java#l151

http://developer.android.com/reference/android/content/Context.html#getExternalFilesDir%28java.lang.String%29

=>

02-27 03:46:06.833: I/dalvikvm(2164): Could not find method android.content.Context.getExternalFilesDir, referenced from method org.mozilla.gecko.GeckoDirProvider.getFilesDir
02-27 03:46:06.843: W/dalvikvm(2164): VFY: unable to resolve virtual method 123: Landroid/content/Context;.getExternalFilesDir (Ljava/lang/String;)Ljava/io/File;

Comment 1

[Richard Newman [:rnewman]]

Nominating per dougt.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

That function will never get called unless we are on API 8+ because of the guard in isOnInternalStorage().

Also note that once maple lands we will be forced up to API 8 anyway.

Comment 3

[Matt Brubeck (:mbrubeck)]

If comment 2 is correct, this does not cause any issues aside from some warnings in the logs.  Resolving as invalid.