GeckoProfile relies on API version 8+ methods

RESOLVED INVALID

Status

()

Firefox for Android
General
RESOLVED INVALID
7 years ago
7 years ago

People

(Reporter: rnewman, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

7 years ago
https://hg.mozilla.org/integration/mozilla-inbound/file/default/mobile/android/base/GeckoProfile.java#l151

http://developer.android.com/reference/android/content/Context.html#getExternalFilesDir%28java.lang.String%29

=>

02-27 03:46:06.833: I/dalvikvm(2164): Could not find method android.content.Context.getExternalFilesDir, referenced from method org.mozilla.gecko.GeckoDirProvider.getFilesDir
02-27 03:46:06.843: W/dalvikvm(2164): VFY: unable to resolve virtual method 123: Landroid/content/Context;.getExternalFilesDir (Ljava/lang/String;)Ljava/io/File;
(Reporter)

Comment 1

7 years ago
Nominating per dougt.
blocking-fennec1.0: --- → ?
That function will never get called unless we are on API 8+ because of the guard in isOnInternalStorage().

Also note that once maple lands we will be forced up to API 8 anyway.
Depends on: 662891
If comment 2 is correct, this does not cause any issues aside from some warnings in the logs.  Resolving as invalid.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → INVALID
blocking-fennec1.0: ? → ---
You need to log in before you can comment on or make changes to this bug.