730784 - Collusion 0.16.1 add-on (prelim.) leaves a zombie compartment behind when disabled

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Nils Maier [:nmaier]]

STR:
- Install and disable the add-on
- about:memory?verbose + Minimize memory usage
-> Compartment or compartments (depending on sameGroupAs availability for sandboxes) still present.

The add-on uses widget, so the leaks are probably a result of the fix for bug 724404 not being present in the SDK 1.5 (see bug 730566 comment 5)

Comment 1

[Jono Xia]

Hi Nils,
Thanks for investigating this problem!
What should I do about it? Is there a workaround, or do I just have to wait for a new release of the SDK and then use it to rebuild the add-on?

Comment 2

[Nils Maier [:nmaier]]

There is no workaround that I know of.

What you can do in the meantime: Get the add-on sdk from github and test that your add-on does not leak when built with the stabilization branch (or master).
https://github.com/mozilla/addon-sdk/
If your add-on still leaks, there might be other, unrelated leaks caused directly by your add-on code which must be fixed.

Please note that we cannot accept add-ons that were built with non-release SDK versions on AMO.

Comment 3

[Nicholas Nethercote [inactive]]

Nils, I wonder if it's worth not reporting these kinds of leaks for a while?  We already have a bunch of them on file and it's the SDK's fault, right?

Comment 4

[Nils Maier [:nmaier]]

(In reply to Nicholas Nethercote [:njn] from comment #3)
> Nils, I wonder if it's worth not reporting these kinds of leaks for a while?
> We already have a bunch of them on file and it's the SDK's fault, right?

I considered that myself... Actually I did/do so when reviewing SDK 1.4.x add-ons.
I guess that there is indeed no added value in creating new bugs where the leaks are clearly a result of the SDK bug. If such add-ons have other bugs, then the next SDK update will expose them.

Care to inform amo-editors-internal?

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Jono: version 1.6 of the SDK is now available. This version should address the pending memory leaks in your add-on. Please upgrade your add-on to use SDK 1.6 and submit a new version as soon as possible.

Comment 6

[Jorge Villalobos [:jorgev] (he/him)]

* pokes Jono again *

Comment 7

[Jono Xia]

Hi Jorge!
Sorry, I was on vacation. I will do this today.

Comment 8

[Jono Xia]

Just rebuilt with SDK 1.6 and pushed the new XPI file to addons.mozilla.org.