73085 - Blackwood needs a good build/packaging system on All supported platforms

Status: RESOLVED FIXED

(Core Graveyard :: Java APIs to WebShell, defect)

Description

[Ashu Kulkarni]

Currently a consistent build/packaging system is not available for all the 
Blackwood projects. For Blackwood-1.0, we need a build system on all platforms 
(win32, linux and solaris) that generates .xpi files for the individual 
components or the whole project as required.

Comment 1

[Ashu Kulkarni]

Attachment: List of files in Patch - actual tar.gz in next attachment

Comment 2

[Ashu Kulkarni]

Attachment: Patch for this Bug - first iteration

Comment 3

[Ashu Kulkarni]

Ed, Igor, Pls review the patch
thnx
_Ashu

Comment 4

[edburns]

After applying this patch to my blackwood tree on win32, nmake -f Makefile.win 
in java does nothing.

Comment 5

[edburns]

I think if no BUILD_X_ONLY is specified, it should default to build_blackwood.

Comment 6

[geetha.vaidyanaathan]

Changing QA contact

Comment 7

[edburns]

After thinking about it, I withdraw my previous stipulation about the default
behaviour.

Comment 8

[edburns]

Attachment: tar -gz of files in fix for this bug second iteration, works with today's trunk.

Comment 9

[edburns]

ra=edburns, wait for my 76405 checkin.

Comment 10

[edburns]

Fix checked in.

Comment 11

[Ashu Kulkarni]

thanks Ed.

Comment 12

[edburns]

fixed

Comment 13

[Ashu Kulkarni]

Another small fix for unix

RCS file: /cvsroot/mozilla/java/makefiles,v
retrieving revision 1.3
diff -u -r1.3 makefiles
--- makefiles   2000/08/03 21:32:54     1.3
+++ makefiles   2001/05/01 18:46:47
@@ -1,6 +1,7 @@
 java/Makefile
 java/util/Makefile
 java/util/classes/Makefile
+java/build/Makefile
 java/webclient/Makefile
 java/webclient/classes_spec/Makefile
 java/webclient/src_share/Makefile

Comment 14

[edburns]

Ashu' what is the change?

Comment 15

[Ashu Kulkarni]

It adds java/build/Makefile to the list of makefiles created when you run
configure --with-java-supplement

Comment 16

[Igor Kushnirskiy]

what is the intention of such "build/packaging"
Is it for webclient or is it for all blackwood projects?

Comment 17

[Ashu Kulkarni]

It is for all Blackwood projects. Using these Makefiles you can select a
particular Blackwood Module (or all modules) and have them built by just running
gmake in mozilla/java. Also by setting a PACKAGE_BUILD variable, you will be
able to generate .xpis for these individual (or all of Blackwood) components.

Comment 18

[Igor Kushnirskiy]

Greate. 
Why do you need mozilla/java/makefiles ?
It seems to be not beeng used.

Comment 19

[Ashu Kulkarni]

running "configure --with-java-supplement" seems to only generate the Makefiles
(from Makefile.in) for the files listed in mozilla/java/makefiles. I have tested
this, however, I haven't investigated which script in the configure system reads
this file.

Comment 20

[Ashu Kulkarni]

With integration of BlackConnect in Webclient, these Makefiles need to be
changed. I will also take this opportunity to remove the WEBCLIENT_PACKAGE_BUILD
target from the webclient/src_moz/Makefile.in file.

Comment 21

[Ashu Kulkarni]

Attachment: cvs diff of patch

Comment 22

[Ashu Kulkarni]

Attachment: tar.gz

Comment 23

[Ashu Kulkarni]

Ed,
Pls review these latest patches. RE needs them to be able to build xpi's and
solaris SVR4 bundles successfully with the new BlackConnect changes in
Webclient. Pls note that although the cvs diff for build/Makefile.in and
Makefile.win looks significant, it's just addition of tabs, the absence of which
was making gmake very angry.
thnx

Comment 24

[edburns]

Ashu, I've untarred your 4:30 pm today tarball into my blackwood pristine 
trunk.  When I set BUILD_BLACKWOOD=1 and run make in java/build,  I get:


Makefile.win(26) : fatal error U1052: file '..\..\config\autoconf.mk' not found
Stop.

Can you please fix this and generate another patch?

Thank you.

Ed

Comment 25

[Ashu Kulkarni]

I'll check the Win makefiles on WinNT tomorrow. Did you test this on Unix. If
the unix side stuff is good, I'll ask for a separate r= from you for that. This
way, RE builds of Blackwood can resume once again. Pls check on linux and
solaris and let me know. I have tested myself on Solaris.

thnx.

Comment 26

[Ashu Kulkarni]

Attachment: tar.gz - thrid iteration - works on Windows and Solaris

Comment 27

[Ashu Kulkarni]

Hi Ed,

This latest patch works on both Windows and Solaris. Pls test on linux and let 
me know if I have r=edburns. thnx much.

Comment 28

[edburns]

Assuming OJI_DISABLE=1 on win32, ra=edburns.

Comment 29

[Ashu Kulkarni]

Fix checked in.

Comment 30

[edburns]

I'm re-opening this.  For some reason my webclient win32 build can't find 
JAWT_GetAwt.  In fact, the src_moz/Makefile.win doesn't even cause the build to 
descend into the win32 directory.  Ashu, can you please fix this?

Thanks,

Ed

Comment 31

[Ashu Kulkarni]

The jawt stuff had gotten backed out by mistake in the last checkin. The Fix for
Win32 has been checked in by Ed. I have checked in the fix for Unix.

Closing Bug.