731004 - Telemetry on time to service idle callbacks

Status: RESOLVED FIXED

(Core :: Widget, defect)

Description

[(dormant account)]

There have been quite a few bugs file on browser being locked up after idle. Lets figure out whether this is still a problem and whether it's caused by blocking idle observers or sql contention.
We need telemetry on:
* time taken by TryNotifyBackState would be a start.
* how many idle reporters are notified at a time.

Comment 1

[Nathan Froyd [:froydnj]]

I will poke at this sometime this week.

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: patch to add telemetry

Although the bug is only for returning telemetry, getting telemetry on idle notifications seemed useful too.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

This doesn't apply cleanly to mozilla-inbound. Please resubmit.

Comment 4

[Nathan Froyd [:froydnj]]

Clearing checkin-needed; I will resubmit later.

Comment 5

[Nathan Froyd [:froydnj]]

Attachment: patch to add telemetry

I realize I got r+ on the last patch, but nsIdleService changed out from under me sufficiently that r?'ing again is worthwhile, I think.

Specifically, WDYT about the placement of the IDLE_NOTIFY_IDLE_MS timer in IdleTimerCallback?  I think it's in the right place; we don't want it much farther before or we'd count time in ResetIdleTimeOut (i.e. IDLE_NOTIFY_BACK_MS).  But I'm not familiar with the code, so I'd like a second opinion.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/592a7bce652a

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

https://hg.mozilla.org/mozilla-central/rev/592a7bce652a