Closed
Bug 731056
Opened 13 years ago
Closed 13 years ago
Fix checkstyle warnings in GeckoInputConnection.java
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 13
People
(Reporter: cpeterson, Assigned: cpeterson)
Details
Attachments
(4 files)
|
19.28 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
2.57 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
5.74 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
|
20.17 KB,
patch
|
dougt
:
review+
|
Details | Diff | Splinter Review |
If I'm going to be fixing lots of bugs in GeckoInputConnection.java, I'd like it to follow the standard Android/Java coding style. :)
|
Assignee | |
Comment 1•13 years ago
|
||
Fix whitespace formatting.
Attachment #601119 -
Flags: review?(doug.turner)
|
|
Assignee | |
Comment 2•13 years ago
|
||
Reorder imports and remove wildcards.
Attachment #601120 -
Flags: review?(doug.turner)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Move field declarations to top of class and make them private.
Attachment #601121 -
Flags: review?(doug.turner)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Wrap lines longer than 100 characters.
|
||
Updated•13 years ago
|
Attachment #601119 -
Flags: review?(doug.turner) → review+
|
|
||
Updated•13 years ago
|
Attachment #601120 -
Flags: review?(doug.turner) → review+
|
|
||
Updated•13 years ago
|
Attachment #601121 -
Flags: review?(doug.turner) → review+
|
|
||
Updated•13 years ago
|
Attachment #601122 -
Flags: review?(doug.turner) → review+
|
|
||
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca9f90e8d26b
https://hg.mozilla.org/integration/mozilla-inbound/rev/728ad9516cd2
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6619abc8872
https://hg.mozilla.org/integration/mozilla-inbound/rev/a1a5f7331cfd
Keywords: checkin-needed
|
||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ca9f90e8d26b
https://hg.mozilla.org/mozilla-central/rev/728ad9516cd2
https://hg.mozilla.org/mozilla-central/rev/f6619abc8872
https://hg.mozilla.org/mozilla-central/rev/a1a5f7331cfd
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 13
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•