Last Comment Bug 731157 - [New Tab Page] thumbnails disappear when switching to private browsing mode
: [New Tab Page] thumbnails disappear when switching to private browsing mode
: uiwanted
Product: Firefox
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
-- normal (vote)
: Firefox 15
Assigned To: Raymond Lee [:raymondlee]
Depends on: 744388
Blocks: 455553
  Show dependency treegraph
Reported: 2012-02-28 02:41 PST by Virgil Dicu [:virgil] [QA]
Modified: 2012-06-07 19:02 PDT (History)
16 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (1.80 KB, patch)
2012-04-24 02:45 PDT, Raymond Lee [:raymondlee]
dao+bmo: feedback-
Details | Diff | Splinter Review

Description User image Virgil Dicu [:virgil] [QA] 2012-02-28 02:41:41 PST
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120227 Firefox/13.0a1

When opening a new tab in private browsing, none of the sites in the grid will display thumbnails.
While this seems normal as the cache doesn't seem to be used, the page does not look very user friendly for a first experience with Private browsing. 
Wouldn't showing a blank new tab page or the private browsing notification fit in better with browsing in private?

FTR, Chrome displays a notification when opening a new tab in incognito mode.
Comment 1 User image (mostly gone) XtC4UaLL [:xtc4uall] 2012-02-28 17:05:17 PST
So a better Summary would rather be "disable the New Tab Page in Private Browsing Mode", no?
Comment 2 User image Tim Taubert [:ttaubert] 2012-02-29 01:43:03 PST

What does the UX team think about this proposal? We could just switch to 'about:blank' when we're in private browsing mode. Otherwise it might make sense to display an immutable 'about:newtab' page when in PB mode to give you access to your bookmarks/sites.
Comment 3 User image Guillaume C. [:ge3k0s] 2012-03-05 04:08:52 PST
What Chrome does isn't bad : it always display the private browsing message when a new tab is opened.
Comment 4 User image Chris Lee [:clee] 2012-03-27 10:51:25 PDT
As an easy fix for this, we can default to 'about:blank' for a new tab when the user is in private mode. 

Longer term, we can be more explicit about private mode and messaging.
Comment 5 User image Raymond Lee [:raymondlee] 2012-04-24 02:45:27 PDT
Created attachment 617828 [details] [diff] [review]

Tim: do you think it would be better to create a new JSM.  This singleton class would has a observer to listen to private-browsing preference and update the "browser.newtab.url" when needed?
Comment 6 User image Dão Gottwald [:dao] 2012-04-24 03:04:26 PDT
Comment on attachment 617828 [details] [diff] [review]

Add-ons can modify browser.newtab.url, so you don't want to just clobber it.

Secondly, changing browser.newtab.url isn't going to be compatible with the private browsing mode becoming window-specific.

Finally, is this still needed at all with the upcoming custom thumbnail storage?
Comment 7 User image Tim Taubert [:ttaubert] 2012-04-24 12:27:00 PDT
Comment on attachment 617828 [details] [diff] [review]

(In reply to Dão Gottwald [:dao] from comment #6)
> Finally, is this still needed at all with the upcoming custom thumbnail
> storage?

Actually, yes, this should be solved with the new storage as we're able to show thumbnails then. Let's not continue to work on this but wait for the storage to be fixed.
Comment 8 User image Tim Taubert [:ttaubert] 2012-05-02 06:57:53 PDT
Fixed by bug 744388.

Note You need to log in before you can comment on or make changes to this bug.