731170 - Download Manager Open containing Folder not working

Status: VERIFIED FIXED

(Core :: XPCOM, defect)

Description

[Jim Jeffery not reading bug-mail 1/2/11]

Open the Download Manager, Ctrl+j or from the Menu button
Pick a download in the listing and right-click 
Choose the option:  Open Containing Folder..
Folder does NOT open.

No errors in Console.
Regression Range:
20120227014549 2dc40eb83023 Good
20120227044549 7d7179d2d809 Bad

Needs triage from m-i builds

Comment 1

[Marco Bonardo [:mak]]

I suppose may be due to bug 632556, it exactly touched that code

Comment 2

[Marco Bonardo [:mak]]

and this makes me think our testing of the functionality may be poor

Comment 3

[Brian R. Bondy [:bbondy]]

Was working with my locally built build, but looking into it now...

Comment 4

[Brian R. Bondy [:bbondy]]

Still works with my locally built build consistently. I'll wait for today's Nightly and try that, maybe it's a release only problem or something like that.

Comment 5

[Brian R. Bondy [:bbondy]]

Works for me on Windows 7.  Reproduced on Windows XP.

Comment 6

[Brian R. Bondy [:bbondy]]

Attachment: Patch v1.

CoInitialize/CoUninitialize must be called implicitly on Win7 for SHOpenFolderAndSelectItems which made it so I didn't notice I forgot to call it after moving the code to a thread.

Could reproduce with my locally built build on my XP machine only as well and confirmed fixed with this patch.

Comment 7

[Brian R. Bondy [:bbondy]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/21c8c7e7e3a8

Comment 8

[NightsoN Blaze]

I can reproduce it on my Windows 7 machine even with a clean profile.Are you sure it is XP only?

Tested with 20120228 nightly build.

Comment 9

[Brian R. Bondy [:bbondy]]

rstrong can reproduce it on his win7 as well so I'm not sure what the difference is, but my win7 definitely cannot reproduce it.  In any case it'll be fixed by the changeset in Comment 7 once it is merged to m-c.

Comment 11

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/mozilla-central/rev/21c8c7e7e3a8

Comment 12

[Jim Jeffery not reading bug-mail 1/2/11]

Verified Fixed using latest hourly m-c build on win32/win7x64 based on cset:

https://hg.mozilla.org/mozilla-central/rev/3812d0ce274e

Comment 13

[Jim Michaels]

well, it's not working again (sort of), in ff26.0, download manager, open containing folder produces an explorer windows that refuses to update in windows 7. a while ago it would update if I hit ctrl-f5 but now even that doesn't work (F5 didn't work).

windows 7 provided file (etc) versioning, so you can take a file back to previous dates. I am guessing this works for 
shortcuts apparently can have a versioning problem in windows 7 where they can get stale or old (this was mentioned against the taskbar on the internet through some googling). wondering if it's elsewhere too, or if it's a specific checkbox or setting in the shortcut that's causing this. I don't know if anything in the download manager is a shortcut or not.

I had thought the problem got fixed too. but I found out where the problem is... it stems from firefox doing something odd with explorer.exe?

Comment 14

[Jim Michaels]

correction, incorrect statement, it's a guess, not an "I found the problem".

Comment 15

[Till Schneidereit [:till]]

Jim, please open a new bug with steps to reproduce for the problem you're seeing. This particular bug has long been fixed and closed, and the problem you're seeing is different from the one dealt with here.