remove CSS computed style getters from nsIAccessible

RESOLVED FIXED in mozilla13

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: surkov, Assigned: surkov)

Tracking

({dev-doc-needed})

unspecified
mozilla13
dev-doc-needed
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 601302 [details] [diff] [review]
patch

No any reason to expose them to a script. Scripts should deal with with DOM stuffs instead.
Attachment #601302 - Flags: review?(askalski)
(Assignee)

Comment 1

5 years ago
Andrzej, ping?

Updated

5 years ago
Attachment #601302 - Flags: review?(askalski) → review?(trev.saunders)
Comment on attachment 601302 [details] [diff] [review]
patch

>diff --git a/accessible/public/nsIAccessible.idl b/accessible/public/nsIAccessible.idl
>--- a/accessible/public/nsIAccessible.idl
>+++ b/accessible/public/nsIAccessible.idl
>@@ -54,17 +54,17 @@ interface nsIAccessibleRelation;
>  * accessibility APIs like MSAA and ATK. Contains the sum of what's needed
>  * to support IAccessible as well as ATK's generic accessibility objects.
>  * Can also be used by in-process accessibility clients to get information
>  * about objects in the accessible tree. The accessible tree is a subset of 
>  * nodes in the DOM tree -- such as documents, focusable elements and text.
>  * Mozilla creates the implementations of nsIAccessible on demand.
>  * See http://www.mozilla.org/projects/ui/accessibility for more information.
>  */
>-[scriptable, uuid(3126544c-826c-4694-a2ed-67bfe56a1f37)]
>+[scriptable, uuid(e7c44e0d-736e-4ead-afee-b51f4b574020)]
> interface nsIAccessible : nsISupports
> {

dev-doc-needed?


> 
>   nsRefPtr<nsAccessible> acc(do_QueryObject(this));
>-  if (!acc)
>+  if (!acc || acc->IsDefunct())
>     return E_FAIL;

if that qi fails something has gone horribly wrong, so I'm not sure you need the null check but I doubt it hurts.
Attachment #601302 - Flags: review?(trev.saunders) → review+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/17012da10279
Keywords: dev-doc-needed
(Assignee)

Comment 4

5 years ago
https://developer.mozilla.org/en/nsIAccessNode and https://developer.mozilla.org/en/nsIAccessible should be updated (nsIAccessNode was removed, all methods were moved to nsIAccessible)
https://hg.mozilla.org/mozilla-central/rev/17012da10279
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.