Last Comment Bug 731276 - remove CSS computed style getters from nsIAccessible
: remove CSS computed style getters from nsIAccessible
Status: RESOLVED FIXED
: dev-doc-needed
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla13
Assigned To: alexander :surkov
:
: alexander :surkov
Mentors:
Depends on:
Blocks: 728127
  Show dependency treegraph
 
Reported: 2012-02-28 09:27 PST by alexander :surkov
Modified: 2012-03-13 05:53 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (8.97 KB, patch)
2012-02-28 09:27 PST, alexander :surkov
tbsaunde+mozbugs: review+
Details | Diff | Splinter Review

Description alexander :surkov 2012-02-28 09:27:20 PST
Created attachment 601302 [details] [diff] [review]
patch

No any reason to expose them to a script. Scripts should deal with with DOM stuffs instead.
Comment 1 alexander :surkov 2012-03-04 23:52:40 PST
Andrzej, ping?
Comment 2 Trevor Saunders (:tbsaunde) 2012-03-09 09:41:30 PST
Comment on attachment 601302 [details] [diff] [review]
patch

>diff --git a/accessible/public/nsIAccessible.idl b/accessible/public/nsIAccessible.idl
>--- a/accessible/public/nsIAccessible.idl
>+++ b/accessible/public/nsIAccessible.idl
>@@ -54,17 +54,17 @@ interface nsIAccessibleRelation;
>  * accessibility APIs like MSAA and ATK. Contains the sum of what's needed
>  * to support IAccessible as well as ATK's generic accessibility objects.
>  * Can also be used by in-process accessibility clients to get information
>  * about objects in the accessible tree. The accessible tree is a subset of 
>  * nodes in the DOM tree -- such as documents, focusable elements and text.
>  * Mozilla creates the implementations of nsIAccessible on demand.
>  * See http://www.mozilla.org/projects/ui/accessibility for more information.
>  */
>-[scriptable, uuid(3126544c-826c-4694-a2ed-67bfe56a1f37)]
>+[scriptable, uuid(e7c44e0d-736e-4ead-afee-b51f4b574020)]
> interface nsIAccessible : nsISupports
> {

dev-doc-needed?


> 
>   nsRefPtr<nsAccessible> acc(do_QueryObject(this));
>-  if (!acc)
>+  if (!acc || acc->IsDefunct())
>     return E_FAIL;

if that qi fails something has gone horribly wrong, so I'm not sure you need the null check but I doubt it hurts.
Comment 4 alexander :surkov 2012-03-12 18:11:30 PDT
https://developer.mozilla.org/en/nsIAccessNode and https://developer.mozilla.org/en/nsIAccessible should be updated (nsIAccessNode was removed, all methods were moved to nsIAccessible)
Comment 5 Marco Bonardo [::mak] 2012-03-13 05:53:14 PDT
https://hg.mozilla.org/mozilla-central/rev/17012da10279

Note You need to log in before you can comment on or make changes to this bug.