731350 - Keep hitting the assertion "We should have a margin here! (out of memory?)"

Status: NEW

(Core :: Layout, defect)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: stack

Applying the patch in bug 711157 I keep hitting this assertion, GetStyleMargin()->GetMargin(margin) in nsIFrame::GetUsedMargin constantly returns false.

I'm attaching the stack at that point.

Comment 1

[Tim Taubert [:ttaubert] (inactive)]

This is seemingly causing some sessionstore tests to randomly time out. We could end up backing out bug 711157 because of this so it's definitely blocking.

Comment 2

[Tim Taubert [:ttaubert] (inactive)]

We hit this problems with a <div> that had 'display: -moz-box' and 'margin: 0 auto'. We actually didn't need the margin here and thus removed it - the assertion disappeared.

Comment 3

[David Humphrey (:humph)]

See also bugs 391157, 586628, 611532.  I'm hitting it when running the test case in https://bug750111.bugzilla.mozilla.org/attachment.cgi?id=619436 when I go fullscreen:

WARNING: Unable to test style tree integrity -- no content node: file /Users/dave/repos/mozilla-central/layout/base/nsCSSFrameConstructor.cpp, line 8001
###!!! ASSERTION: We should have a margin here! (out of memory?): 'hasMargin', file /Users/dave/repos/mozilla-central/layout/generic/nsFrame.cpp, line 845