731372 - java.lang.NullPointerException: at org.mozilla.gecko.GeckoApp$SessionSnapshotRunnable.run(GeckoApp.java:598)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

02-28 11:49:28.224 29910 29919 E AndroidRuntime: FATAL EXCEPTION: GeckoBackgroundThread
02-28 11:49:28.224 29910 29919 E AndroidRuntime: java.lang.NullPointerException
02-28 11:49:28.224 29910 29919 E AndroidRuntime: 	at org.mozilla.gecko.GeckoApp$SessionSnapshotRunnable.run(GeckoApp.java:598)
02-28 11:49:28.224 29910 29919 E AndroidRuntime: 	at android.os.Handler.handleCallback(Handler.java:587)
02-28 11:49:28.224 29910 29919 E AndroidRuntime: 	at android.os.Handler.dispatchMessage(Handler.java:92)
02-28 11:49:28.224 29910 29919 E AndroidRuntime: 	at android.os.Looper.loop(Looper.java:130)
02-28 11:49:28.224 29910 29919 E AndroidRuntime: 	at org.mozilla.gecko.GeckoBackgroundThread.run(GeckoBackgroundThread.java:31)
02-28 11:49:28.224   508   873 W ActivityManager:   Force finishing activity org.mozilla.fennec_brian/.App

STR:
1) Open Fennec. Stay at about:home
2) Click the Android home button
3) Run oom-fennec
4) Open Fennec

This will often (not always) crash and close Fennec.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: patch

Adds extra null checks. This particular crash was caused by mLastSnapshotUri being null, which it *always* is the first time we run the SessionSnapshotRunnable.

Comment 2

[Brian Nicholson (:bnicholson)]

Attachment: patch v2

Refactored to simplify checks and remove unnecessary null checks as suggested by kats.

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 601402 [details] [diff] [review]
patch v2

Review of attachment 601402 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +593,3 @@
>                  if (viewportJSON.equals(mLastViewport) &&
> +                    lastHistoryEntry.mTitle.equals(mLastTitle) &&
> +                    lastHistoryEntry.mUri.equals(mLastSnapshotUri))

can lastHistoryEntry, lastHistoryEntry.mTitle or lastHistoryEntry.mUri be null?

Comment 4

[Brian Nicholson (:bnicholson)]

(In reply to Brad Lassey [:blassey] from comment #3)
>
> can lastHistoryEntry, lastHistoryEntry.mTitle or lastHistoryEntry.mUri be
> null?

No; we check lastHistoryEntry == null a few lines above, and the HistoryEntry comments for mUri and mTitle say "must never be null".

Comment 5

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/967583dbaa67

Comment 6

[Brian Nicholson (:bnicholson)]

(In reply to Brian Nicholson (:bnicholson) from comment #5)
> http://hg.mozilla.org/integration/mozilla-inbound/rev/967583dbaa67

Ignore this, wrong link. Corrected inbound link:
http://hg.mozilla.org/integration/mozilla-inbound/rev/ea603d53c3b8

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/ea603d53c3b8