731389 - Startup madness: loadLibsSetup is called twice

Status: RESOLVED DUPLICATE of bug 731341

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

GeckoThread has the following code:

        GeckoAppShell.ensureSQLiteLibsLoaded(resourcePath);
        GeckoAppShell.loadGeckoLibs(resourcePath);

Both of those functions call loadLibsSetup, which potentially does a bunch of file operations and could be expensive. Calling it twice probably hurts our startup time. The code flow here should be cleaned up so we only run the function once.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

See related bug; a refactoring to fix this should also fix that NPE.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

A first thing could be to figure out what part of loadLibsSetup is actually needed for loading the libs - there seems to be quite some Gecko setup in there that probably is unrelated to that.

Comment 3

[Kevin Brosnan [Ex-Mozilla]]

Any idea of the scope of the startup win here? 10s of ms, 100s of ms? This would help understand if this blocks or not.

Comment 4

[Wesley Johnston (:wesj)]

I'm fixing this in bug 731341. The win (for me at least) is 10s of ms, but I'm not on the worlds worst file system.

Comment 5

[Wesley Johnston (:wesj)]

I should probably be clearer. I was seeing times in the range of 30-50 ms spent the first time these functions were called. I'm not sure what amount of time subsequent calls would take.

Comment 6

[Doug Turner (:dougt)]

marking as a dup of 731341