Closed
Bug 731521
Opened 13 years ago
Closed 13 years ago
border-width:0 interferes with inheritance of border-style
Categories
(Core :: CSS Parsing and Computation, defect)
Tracking
()
RESOLVED
FIXED
mozilla14
People
(Reporter: jruderman, Assigned: bzbarsky)
References
Details
(Keywords: testcase)
Attachments
(3 files, 2 obsolete files)
No description provided.
|
Reporter | |
Comment 1•13 years ago
|
||
|
Assignee | |
Comment 2•13 years ago
|
||
The actual nsStyleBorder for the <body> ends up correct. What's not correct is the thing stored in UsedBorderProperty()....
|
|
Assignee | |
Comment 3•13 years ago
|
||
Oh, this is fun.
So for the <html> the computed border width does not change. It's 0px both before and after. Therefore for the <html> there is no reflow hint.
But nsStyleBorder returns false for ForceCompare(), so when we recompute the border for the <body> we skip comparing the old and new values, since mRuleNode is the same as before. We thus don't notice that _its_ computed border has changed, don't trigger a reflow of the body, and thus don't update its used border.
I believe, per the documentation for ForceCompare(), that it should return true for nsStyleBorder.
|
|
Assignee | |
Comment 4•13 years ago
|
||
Attachment #601630 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → bzbarsky
Whiteboard: [need review]
|
|
Assignee | |
Comment 5•13 years ago
|
||
Attachment #601631 -
Flags: review?(dbaron)
|
|
Assignee | |
Updated•13 years ago
|
Attachment #601630 -
Attachment is obsolete: true
Attachment #601630 -
Flags: review?(dbaron)
Comment on attachment 601631 [details] [diff] [review]
Computed border on our descendants can change due to a change of our specified border styles even if our computed border did not change.
r=dbaron. Sorry for the delay. (I managed to discover this too, in bug 741012; there may be some other issues there we need to fix.)
Attachment #601631 -
Flags: review?(dbaron) → review+
|
|
Assignee | |
Comment 7•13 years ago
|
||
Flags: in-testsuite+
Whiteboard: [need review]
Target Milestone: --- → mozilla14
|
|
Assignee | |
Comment 8•13 years ago
|
||
|
||
Comment 9•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Attachment #659157 -
Flags: review?(bzbarsky)
Comment on attachment 659157 [details] [diff] [review]
Refix in the new setup for forcing comparison in nsStyleContext::CalcDifference, since we can no longer rely on nsStyleBorder::ForceCompare. (Bug 779968, patch 5)
Aargh, hg bzexport put this on the wrong bug.
Attachment #659157 -
Attachment is obsolete: true
Attachment #659157 -
Flags: review?(bzbarsky)
|
||
Comment 12•12 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•