731589 - Move mod_perl's max_unshared size from mod_perl.pl to localconfig

Status: RESOLVED FIXED

(Bugzilla :: Installation & Upgrading, enhancement)

Comment 1

[:glob ✱]

oops.

we should move mod_perl's max_unshared size from mod_perl.pl to localconfig

the upper limit for apache processes varies between bugzilla installs (dependent on the perl version, module versions, installed bugzilla extensions, etc), and can also change between different webheads if they don't have identical quantities of ram.

it really should be a localconfig setting, not hardcoded into mod_perl.pl

Comment 2

[Max Kanat-Alexander]

Or perhaps it should be adaptive and persistent in the database. :-)

Comment 3

[Max Kanat-Alexander]

BTW, I'd be against putting this into localconfig because I wanted to slim down that file--I'm trying to avoid exposing people to too many configuration variables in a text file they have to edit by hand.

Perhaps instead you could put it into Constants.pm? There's a fairly long-standing tradition of putting stuff into there that some installations will want to change but most won't.

Comment 4

[:glob ✱]

(In reply to Max Kanat-Alexander from comment #3)
> BTW, I'd be against putting this into localconfig because I wanted to slim
> down that file--I'm trying to avoid exposing people to too many
> configuration variables in a text file they have to edit by hand.
> 
> Perhaps instead you could put it into Constants.pm? There's a fairly
> long-standing tradition of putting stuff into there that some installations
> will want to change but most won't.

heh, so you're against putting in a text file they have to edit by hand, and your proposal is a text file they have to edit by hand :)


both of your proposals, constants.pm and database, assume all webheads are identical.  should we care about sites where this isn't the case?

Comment 5

[Max Kanat-Alexander]

(In reply to Byron Jones ‹:glob› from comment #4)
> heh, so you're against putting in a text file they have to edit by hand, and
> your proposal is a text file they have to edit by hand :)

  Ha, no. I'm against putting it in a text file that *every* administrator has to look at, and in favor of putting it in a text file that almost no administrator has to look at.

> both of your proposals, constants.pm and database, assume all webheads are
> identical.  should we care about sites where this isn't the case?

  Mmm, I'd make the judgment on whether or not you have concrete examples, and then whether or not those concrete examples are so huge that they will have custom developer staff to solve these problems for them.

Comment 6

[:glob ✱]

(In reply to Max Kanat-Alexander from comment #5)
>   Mmm, I'd make the judgment on whether or not you have concrete examples,
> and then whether or not those concrete examples are so huge that they will
> have custom developer staff to solve these problems for them.

this was the case for a long time with bmo - the primary cluster's webheads had less ram than the redundant cluster.  due to code being shared across both sites, i was unable to tweak mod_perl's sizelimit.  (this issue has been fixed by installing more ram).

while we have the resources to customise bugzilla to work around this issue, aside from using localconfig, we would have probably had to hardcode hostnames/networks into bugzilla code, which is unattractive.

i'm not against shifting it into constants, i just want to ensure we're clear on the pros and cons of choosing that over localconfig.

Comment 7

[Max Kanat-Alexander]

  Ah, okay. I think that bugzilla.mozilla.org is in a pretty unusual situation, and so putting it into localconfig would make sense for you guys, but probably not for everybody. For the normal case, putting it in constants would work, and then you could make that read from localconfig or something for your local customization.

Comment 8

[:glob ✱]

moving it from mod_perl.pl to constants.pm doesn't save us anything in terms of differing from upstream -- it won't address the issue where different webheads/clusters/instances have different amounts of installed ram without further code customisations.

i'm going to WONTFIX this and apply a custom fix directly to mod_perl.pl for bmo (bug 827808).

Comment 9

[Dylan Hardison [:dylan] (he/him)]

Attachment: 731589_1.patch

Comment 10

[:glob ✱]

relnote? for the increase to the default memory requirements.

Comment 11

[David Lawrence [:dkl]]

Comment on attachment 8709814 [details] [diff] [review]
731589_1.patch

Review of attachment 8709814 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 12

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/bugzilla/bugzilla.git
   a8512ce..8c54443  master -> master