731610 - Pressing back button in popup window should close the popup

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Paul Feher]

Fennec/13.0a1 2012-02-29
Device: Motorola Droid Pro ( Android 2.3.3)

Steps to reproduce:
1. Open Fennec and wait for the page to load.
2. Go to popuptest.com/popuptest1.html.
3. Set the preferences to "Always allow popups".
4. Reload the page and wait for all the pop-ups to open.
5. Press the back button a few time to dismiss the pop-ups.

Expected results:
Every time the back button is pressed a pup-up is dismissed until the page that generated pop-ups is displayed.

Actual results:
After closing one pop-up the main page is brought up as the active tab. Pressing back performs a browser back or minimizes the app depending on how many history items there are for the current tab.

Notes:
-- The issue is not reproducible on the Firefox Beta 11.0 XUL

Comment 1

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

adding madhava, and ibarlow to see what they say about this ux issue.

Comment 3

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

I think Martijn's wording summarizes the issue a little better.

Comment 4

[Matt Brubeck (:mbrubeck)]

It is intentional that pressing the Back key while viewing a popup returns to the parent page.  (See bug 699052 comment 4.)  In fact, XUL Fennec was supposed to behave the same way so I am surprised that it doesn't:
https://hg.mozilla.org/mozilla-central/file/78e56fd22f2a/mobile/xul/chrome/content/browser-ui.js#l897

But we can certainly change this if UX wants us to.

Comment 5

[Matt Brubeck (:mbrubeck)]

Ian, what is the desired behavior here?

Comment 6

[Ian Barlow (:ibarlow)]

Pressing the back button on any popup should take you back to the parent page, not other popups. Having to back back back back through a series of popups would be a poor experience.

As an aside, pressing back from a popup closes the app entirely right now, which is also wrong.

Comment 7

[Matt Brubeck (:mbrubeck)]

(In reply to Ian Barlow (:ibarlow) from comment #6)
> Pressing the back button on any popup should take you back to the parent
> page, not other popups. Having to back back back back through a series of
> popups would be a poor experience.

Okay, closing this bug as WONTFIX then, since this is the current behavior (at least when it's working correctly...).

Now, of course closing multiple popups is potentially annoying no matter what the back button does, so hopefully our popup blocker will prevent users from getting into this situation to begin with in most cases.

> As an aside, pressing back from a popup closes the app entirely right now,
> which is also wrong.

Yes, I'm seeing this too.  I'll file this a separate bug; I think it is a regression.

Comment 8

[Matt Brubeck (:mbrubeck)]

(In reply to Matt Brubeck (:mbrubeck) from comment #7)
> > As an aside, pressing back from a popup closes the app entirely right now,
> > which is also wrong.
> 
> Yes, I'm seeing this too.  I'll file this a separate bug; I think it is a
> regression.

Actually, re-reading, I see that this is the main issue reported in *this* bug.  Sorry for misunderstanding; I got confused by the separate issue of which tab is selected *after* the popup is closed.  Re-opening this bug and re-titling it again.  The correct behavior when back is pressed should be to close the popup and select the parent tab.

Comment 9

[Matt Brubeck (:mbrubeck)]

Attachment: patch

Comment 10

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 604146 [details] [diff] [review]
patch

so simple. <3

Comment 11

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b53e140ae296

Comment 12

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/b53e140ae296

Comment 13

[Paul Feher]

Verified fixed on:
Nightly Fennec 13.0a1 (2012-03-09)
Device: HTC Desire Z
OS: Android 2.3.3