Closed Bug 731618 Opened 8 years ago Closed 8 years ago

Remove JSContext * parameter from heap iteration API

Categories

(Core :: JavaScript Engine, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: igor, Assigned: igor)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #723286 +++

To minimize the patch fro the bug 723286 I will do removal of cx parameter from various API that we use to collect heap statistics in a separated bug.
Attached patch v1Splinter Review
The patch replaces JSContext *cx with JSRuntime *rt in various heap iteration api and removes the code that previously had to created temporary cx instances when reporting heap statistics.
Assignee: general → igor
Attachment #601635 - Flags: review?(wmccloskey)
Comment on attachment 601635 [details] [diff] [review]
v1

Review of attachment 601635 [details] [diff] [review]:
-----------------------------------------------------------------

Great!

::: js/src/jsapi.h
@@ +2689,1 @@
>                JSCompartment *compartment);

Can you fix the spacing here?
Attachment #601635 - Flags: review?(wmccloskey) → review+
https://hg.mozilla.org/mozilla-central/rev/4e0b2de5f2cb
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.