Closed Bug 731636 Opened 10 years ago Closed 10 years ago

IonMonkey: Move emitter shouldn't clobber the spilled register for reg -> reg moves

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: jandem, Assigned: jandem)

References

Details

Attachments

(1 file)

Attached patch PatchSplinter Review
check-crypto-sha1.js fails on x86 with --ion-licm=off --ion-gvn=off. I thought it was an LSRA bug, but it turns out to be a bug in the move emitter.

For memory -> register moves, we would reset spilledReg_ if spilledReg_ == to, to avoid overwriting it later, but not for register -> register moves.
Attachment #601626 - Flags: review?(dvander)
Attachment #601626 - Flags: review?(dvander) → review+
https://hg.mozilla.org/projects/ionmonkey/rev/c84b1bfea7cd
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.