73169 - NS_NewLocalFileOutputStream is not working on Mac this case

Status: VERIFIED FIXED

(Core :: Networking: File, defect)

Description

[Syd Logan]

This always fails, regardless of new file or replace:

        nsCOMPtr<nsIOutputStream> outStream;
        rv = NS_NewLocalFileOutputStream(getter_AddRefs(outStream),
                file, PR_CREATE_FILE | PR_WRONLY | PR_TRUNCATE, 0644);
        if ( NS_FAILED(rv) ) {

works fine on Linux, Windows. The "file" argument is:

	nsISupports *pFile
        nsCOMPtr<nsIFile> file(do_QueryInterface(pFile, &rv));
        if(NS_FAILED(rv))
                return rv;

pFile was returned by nsIFilePicker

Comment 1

[Doug Turner (:dougt)]

Attachment: Renaming XPCOM Streams.

Comment 2

[Doug Turner (:dougt)]

Attachment: Plugin Diff

Comment 3

[Doug Turner (:dougt)]

My posting in the xpcom ng:

The nsIInputStream and nsIOutputStream implementations in XPCOM are going to be
renamed from nsIFileInputStream and nsIFileOutputStream to
nsIFileSpecInputStream and nsIFileSpecOutputStream repectively.  Also, the IDL
name will be renamed to match.

This will be done because there are a few places where one need to include both
of these implementions.  The result is undefined as to which interface you will
get (or at least on the mac).  
----

sfraser, can you r= these two patches.  
scott, can you sr= these two patches.

Comment 4

[Simon Fraser [no longer active]]

Patches look fine, r=sfraser

Comment 5

[Darin Fisher]

sr=darin

Comment 6

[Syd Logan]

syd is testing on commercial

Comment 7

[Doug Turner (:dougt)]

Syd, just update.  I landed these changes this afternoon!  :-)

Comment 8

[Doug Turner (:dougt)]

I just verified this and it now works.

Comment 9

[Bradley Baetz (:bbaetz)]

code level change.

VERIFIED