Beginning on October 25th, 2016, Persona will no longer be an option for authentication on BMO. For more details see Persona Deprecated.
Last Comment Bug 731783 - GC: Eliminate per-compartment barrier marker
: GC: Eliminate per-compartment barrier marker
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla13
Assigned To: Bill McCloskey (:billm)
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2012-02-29 14:07 PST by Bill McCloskey (:billm)
Modified: 2012-03-02 06:22 PST (History)
3 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (16.14 KB, patch)
2012-02-29 14:07 PST, Bill McCloskey (:billm)
igor: review+
Details | Diff | Splinter Review

Description Bill McCloskey (:billm) 2012-02-29 14:07:19 PST
Created attachment 601754 [details] [diff] [review]

We don't need this anymore since the runtime is now single-threaded.

I also fixed GCMarker::stop so that it releases memory that was allocated during the collection.
Comment 1 Igor Bukanov 2012-02-29 15:23:14 PST
Comment on attachment 601754 [details] [diff] [review]

Review of attachment 601754 [details] [diff] [review]:

Comment 2 Bill McCloskey (:billm) 2012-02-29 15:24:14 PST
Just so it's clear, this won't decrease memory usage by much at all. The stuff that we were pushing onto the per-compartment mark stack will now be pushed onto the per-runtime mark stack. But I guess that's a little better from a memshrink perspective because we have a memory reporter for the latter and not for the former.
Comment 3 Nicholas Nethercote [:njn] 2012-02-29 15:29:42 PST
> Just so it's clear, this won't decrease memory usage by much at all.

I clarified this with billm on IRC.  With heavy usage the MarkStack can grow a lot.  E.g. with MemBench it gets up to 2.8MB.  Prior to this patch, once grown it would never shrink again, but with this patch it will shrink back to 256KB.
Comment 5 Marco Bonardo [::mak] 2012-03-02 06:22:29 PST

Note You need to log in before you can comment on or make changes to this bug.