Closed
Bug 731804
Opened 13 years ago
Closed 13 years ago
nsXPCWrappedJSClass::GetNamedPropertyAsVariant should jsvalify strings _after_ changing compartments
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
I'm guessing this wasn't an issue before because we only hit this stuff for chrome, and chrome was always one compartment. But I'm getting a compartment mismatch with compartment-per-global. Patch coming right up.
|
Assignee | |
Comment 1•13 years ago
|
||
Attaching a patch. Flagging peterv for review.
Attachment #601776 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•13 years ago
|
||
(FWIW, I considered just doing JS_WrapValue here, but we can pretty easily avoid the cross-compartment wrapper if we're careful).
|
||
Updated•13 years ago
|
Attachment #601776 -
Flags: review?(peterv) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=2de207ee1107
|
|
Assignee | |
Comment 4•13 years ago
|
||
Linux and Android look green, and everything at least made it past the build phase. Pushed to m-i:
http://hg.mozilla.org/integration/mozilla-inbound/rev/d4433c487dc8
Target Milestone: --- → mozilla13
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•