731828 - No bug data loaded on some topcrash reports, "a is undefined" JS error

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

Since 2.4.4 landed, https://crash-stats.mozilla.com/topcrasher/byversion/Firefox/10.0.2/7 doesn't load bug data any more, we never get the fixed state and bug summaries for listed bugs.
In the error console or web console, the JS error "a is undefined" comes up.

https://crash-stats.mozilla.com/topcrasher/byos/Firefox/10.0.2/Linux/7/browser interestingly shows the bug data and doesn't show this JS error.


Here's what lonnen said on IRC about this JS error:
<lonnen> on nightly, once the correlation reports start loading, I get the cryptic [14:25:03.575] a is undefined @ https://crash-stats.mozilla.com/js/jquery/jquery-1.6.4.min.js:2
<lonnen> where a is a minified var inside jquery, useless
<lonnen> but possibly related to the upgrade to jquery-1.6.4


As I see this only when bug data doesn't load correctly, I think it's related to that and not to correlations, as those never load correctly, even on the pages where this error doesn't come up. I'll file yet another bug report on those.

Comment 1

[Lonnen :lonnen]

Rhelmer and myself are unable to repro a lack of bug data. It shows up in prod without a problem. The 'a is undefined' JS error is related to the correlation reports never loading, bug 731830.

Comment 2

[Lonnen :lonnen]

https://github.com/mozilla/socorro/blob/master/webapp-php/js/socorro/bugzilla.js#L17

if data is empty, data.bugs will be undefined and each will error.

Comment 5

[Laura Thomson :laura]

Should spin a dot point release for this one, today preferably.

Comment 6

[Lonnen :lonnen]

So it looks like the correlation reports still load, the spinner animation just doesn't go away. Clicking 'show more' will reveal them.

Given that, with a point release we could keep the superficial JS error from being reported without fixing the underlying problem of bugzilla metadata missing, and possibly fix the loading spinners disappearing when correlations are loaded.

KaiRo has said we can wait till the next release if that's all that will be restored. I'll be putting the short term fix into the 2.5 stage branch.

Comment 7

[[github robot]]

Commits pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e32e4f0ad36b731782d0d4d1a049776901083032
bug 731828 look before leaping to avoid js errors

https://github.com/mozilla/socorro/commit/69569ca36131ca442d7f0166d1e6726887f78334
Merge pull request #407 from Lonnen/bug731828-regression-stage

Bug731828 regression stage

Comment 8

[Lonnen :lonnen]

This band aid will prevent the JS error, and has landed for 2.5 in the stage branch. I've filed Bug 732244 to address the deeper issue.

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/55811731ad28094fdb7d3b8edaf9674431012a1d
bug 731828 look before leaping to avoid js errors

https://github.com/mozilla/socorro/commit/fc40189957e5026af53d55817b6db1aeb6a3a910
Merge pull request #406 from Lonnen/731828-regression

bug 731828 look before leaping to avoid js errors

Comment 10

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verifed on stage - the undefined JS errors are no longer being expressed in the web console.

https://crash-stats.allizom.org/topcrasher/byversion/Firefox/12.0a2/7#
https://crash-stats.allizom.org/topcrasher/byversion/Firefox/13.0a1/7#
https://crash-stats.allizom.org/topcrasher/byversion/FennecAndroid/12.0a2/7/all