731917 - plugin corrupts the stack with ipc disabled

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Ginn Chen]

See also Bug 535073, Bug 348247

With Bug 675553, we introduced this bug.

Since Flashplayer is already using "int" for NPPVpluginNeedsXEmbed, we need to revert the change and set Bug 348247 as won't fix.

This bug caused a misbehavior on SPARC because it is big-endian.

Comment 1

[Ginn Chen]

Attachment: patch

Comment 2

[Karl Tomlinson (:karlt)]

The CallSetWindow regression is from bug 675553:
http://hg.mozilla.org/mozilla-central/diff/e7854b4d29ba/dom/plugins/base/nsPluginNativeWindowGtk2.cpp
While the NPNVxDisplay code has differed since original implementation (as reported in bug 348247):
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/plugin/base/src/ns4xPlugin.cpp&rev=1.103#1231

Comment 3

[Karl Tomlinson (:karlt)]

Comment on attachment 602212 [details] [diff] [review]
patch

>+      // treats NPPVpluginNeedsXEmbed as bool (int), and

Replace "bool" with "PRBool", please.  That is probably also a regression from bug 675553.

>+      PRUint32 needsXEmbed = 0;

And please replace PRUint32 with "int" to match PRBool.

And as you suggest these should be the same in CallSetWindow and in NPNVxDisplay.

Comment 4

[Ginn Chen]

Attachment: patch

also fix the origin

Comment 5

[Karl Tomlinson (:karlt)]

Comment on attachment 602242 [details] [diff] [review]
patch

Thanks!

Comment 6

[Ginn Chen]

http://hg.mozilla.org/integration/mozilla-inbound/rev/02dcec807422

Comment 7

[Marco Bonardo [:mak]]

https://hg.mozilla.org/mozilla-central/rev/02dcec807422