See also Bug 535073, Bug 348247 With Bug 675553, we introduced this bug. Since Flashplayer is already using "int" for NPPVpluginNeedsXEmbed, we need to revert the change and set Bug 348247 as won't fix. This bug caused a misbehavior on SPARC because it is big-endian.
Created attachment 602212 [details] [diff] [review] patch
Assignee: nobody → ginn.chen
Status: NEW → ASSIGNED
Attachment #602212 - Flags: review?(karlt)
The CallSetWindow regression is from bug 675553: http://hg.mozilla.org/mozilla-central/diff/e7854b4d29ba/dom/plugins/base/nsPluginNativeWindowGtk2.cpp While the NPNVxDisplay code has differed since original implementation (as reported in bug 348247): http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/modules/plugin/base/src/ns4xPlugin.cpp&rev=1.103#1231
Comment on attachment 602212 [details] [diff] [review] patch >+ // treats NPPVpluginNeedsXEmbed as bool (int), and Replace "bool" with "PRBool", please. That is probably also a regression from bug 675553. >+ PRUint32 needsXEmbed = 0; And please replace PRUint32 with "int" to match PRBool. And as you suggest these should be the same in CallSetWindow and in NPNVxDisplay.
Attachment #602212 - Flags: review?(karlt) → review+
Created attachment 602242 [details] [diff] [review] patch also fix the origin
Comment on attachment 602242 [details] [diff] [review] patch Thanks!
Attachment #602242 - Flags: review?(karlt) → review+
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in before you can comment on or make changes to this bug.