IonMonkey: Failing jaeger/bug597871.js

RESOLVED FIXED

Status

()

RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: dvander, Assigned: dvander)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Segfault, looks like a regression from my iterator patch.
Created attachment 602228 [details] [diff] [review]
fix

Bleh. Bug is, if we call CloseIterator from JIT, IonActivation::savedEnumerators will be out of date. So this patch just updates the saved value.
Attachment #602228 - Flags: review?(luke)

Comment 2

7 years ago
Comment on attachment 602228 [details] [diff] [review]
fix

Alternatively, you could name it popSavedEnumerator() and have it assert that ion->savedEnumerator->prev == cx->enumerator before popping.  (I'm not sure if that property holds.)
Attachment #602228 - Flags: review?(luke) → review+
http://hg.mozilla.org/projects/ionmonkey/rev/3f39437bb2cc
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.