731950 - Port |Bug 674720 - WebContacts (or Contacts+)| to SeaMonkey

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P3)

Comment 1

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Package "WebContacts" in SeaMonkey [Checked in: Comment 4]

Comment 2

[Ian Neal]

What are the pros and cons for having this?

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to Ian Neal from comment #2)
> What are the pros and cons for having this?

Pro: support (Core) component/interface, so whoever (like add-ons) wants to use it can.
Con: should be none.

In short, it's [my] usual practice to make Core/Toolkit features available.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 601912 [details] [diff] [review]
(Av1) Package "WebContacts" in SeaMonkey
[Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/1579d4c374e8

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1) Add ContactManager.js to SeaMonkey removed-files.in [Checked in: Comment 11]

I just remembered SM wants this too, even though FF missed this part.

Comment 6

[Serge Gautherie (:sgautherie)]

Comment on attachment 602618 [details] [diff] [review]
(Bv1) Add ContactManager.js to SeaMonkey removed-files.in
[Checked in: Comment 11]

While here, I'm merging the 2 omni.jar lines (from bug 701875).

Comment 7

[Ian Neal]

Comment on attachment 602618 [details] [diff] [review]
(Bv1) Add ContactManager.js to SeaMonkey removed-files.in
[Checked in: Comment 11]

>+++ b/suite/installer/removed-files.in
>@@ -302,16 +302,17 @@ modules/searchSpec.js
>     msvcr100.dll
>   #endif
>   #if _MSC_VER != 1700
>     msvcp110.dll
>     msvcr110.dll
>   #endif
> #endif
> @DLL_PREFIX@mozlcms@DLL_SUFFIX@
>+omni.jar
Why here? Wouldn't it be better just before #ifdef MOZ_OMNIJAR?

r=me with that answered/addressed

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 602618 [details] [diff] [review]
(Bv1) Add ContactManager.js to SeaMonkey removed-files.in
[Checked in: Comment 11]

(In reply to Ian Neal from comment #7)
> > @DLL_PREFIX@mozlcms@DLL_SUFFIX@
> >+omni.jar
> Why here? Wouldn't it be better just before #ifdef MOZ_OMNIJAR?

Just the sort order: between m and p. I considered it's not really related to that MOZ_OMNIJAR block anymore.
Yet either place would work...

Comment 9

[Serge Gautherie (:sgautherie)]

http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1330791322.1330793396.13388.gz&fulltext=1
Linux x86-64 comm-central-trunk build on 2012/03/03 08:15:22

V.Fixed

Comment 10

[Ian Neal]

Comment on attachment 602618 [details] [diff] [review]
(Bv1) Add ContactManager.js to SeaMonkey removed-files.in
[Checked in: Comment 11]

Whichever position you prefer is fine.

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 602618 [details] [diff] [review]
(Bv1) Add ContactManager.js to SeaMonkey removed-files.in
[Checked in: Comment 11]

http://hg.mozilla.org/comm-central/rev/3ff2b8c3cb09

Comment 12

[Robert Kaiser]

(In reply to Ian Neal from comment #2)
> What are the pros and cons for having this?

Pro: Supporting a(n upcoming) web standard.
Con: No idea if there are any.

IMHO, it would be great if at some point those WebContacts would have some integration with our address book, but unless someone does the unusual step to bring some innovation into SeaMonkey, I guess that won't happen. Surely not here in any case, would need to be a followup anyhow.

Comment 13

[Serge Gautherie (:sgautherie)]

(In reply to Robert Kaiser (:[e-mail]) from comment #12)
> IMHO, it would be great if at some point those WebContacts would have some
> integration with our address book, but unless someone does the unusual step
> to bring some innovation into SeaMonkey, I guess that won't happen. Surely
> not here in any case, would need to be a followup anyhow.

Sure. Just file a bug: a comment here will probably just get lost, as you implied.