GCLI listeners should be past tense

RESOLVED FIXED in Firefox 15

Status

()

Firefox
Developer Tools: Console
P3
normal
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jwalker, Unassigned)

Tracking

unspecified
Firefox 15
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

In this code:
> this.thing.onAction.add(this.onAction, this);

this.thing.onAction is an event source while this.onAction is a listener.
It's confusing having the same naming standard for both. We should have:

> this.thing.onAction.add(this.actioned, this);

So this.thing.onAction is an event source while this.actioned is a listener.
GCLI Triage.
Fixed with the closing of bug 720641
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 14 → Firefox 15
You need to log in before you can comment on or make changes to this bug.