Last Comment Bug 731957 - GCLI listeners should be past tense
: GCLI listeners should be past tense
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: unspecified
: All All
: P3 normal (vote)
: Firefox 15
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-01 03:52 PST by Joe Walker [:jwalker] (needinfo me or ping on irc)
Modified: 2012-04-29 10:38 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments

Description Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-03-01 03:52:29 PST
In this code:
> this.thing.onAction.add(this.onAction, this);

this.thing.onAction is an event source while this.onAction is a listener.
It's confusing having the same naming standard for both. We should have:

> this.thing.onAction.add(this.actioned, this);

So this.thing.onAction is an event source while this.actioned is a listener.
Comment 1 Joe Walker [:jwalker] (needinfo me or ping on irc) 2012-04-29 10:38:56 PDT
GCLI Triage.
Fixed with the closing of bug 720641

Note You need to log in before you can comment on or make changes to this bug.