Closed
Bug 731957
Opened 14 years ago
Closed 13 years ago
GCLI listeners should be past tense
Categories
(DevTools :: Console, defect, P3)
DevTools
Console
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 15
People
(Reporter: jwalker, Unassigned)
Details
In this code:
> this.thing.onAction.add(this.onAction, this);
this.thing.onAction is an event source while this.onAction is a listener.
It's confusing having the same naming standard for both. We should have:
> this.thing.onAction.add(this.actioned, this);
So this.thing.onAction is an event source while this.actioned is a listener.
|
Reporter | |
Comment 1•13 years ago
|
||
GCLI Triage.
Fixed with the closing of bug 720641
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 14 → Firefox 15
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•