731968 - intermittent toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | (some guid number) == 1234567890AB

Status: RESOLVED FIXED

(Toolkit :: Places, defect)

Description

[Marco Bonardo [:mak]]

https://tbpl.mozilla.org/php/getParsedLog.php?id=9741720&tree=Mozilla-Inbound

TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | Starting test_addLivemark_forceGuid_callback_succeeds

TEST-INFO | (xpcshell/head.js) | test 2 finished

TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | [null : 292] true == true

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | 2oISlZ4_JHLa == 1234567890AB - See following stack:
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 462
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: _do_check_eq :: line 556
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_eq :: line 577
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js :: <TOP_LEVEL> :: line 293
JS frame :: resource:///components/nsLivemarkService.js :: LS_addLivemark_ETAT :: line 422

Comment 1

[Marco Bonardo [:mak]]

and this actually happens because the guid is written asynchronously, so on creation we may callback before all writes are done, that is pretty bad for Sync.

Comment 2

[Marco Bonardo [:mak]]

Attachment: patch v1.0

unfortunately I can't write a test here, the async write may happen at any time, even synchronously if the scheduler decides so.

Comment 3

[Marco Bonardo [:mak]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a3b1c010b101

Comment 4

[Legacy TBPL/Treeherder Robot]

ryanvm%gmail.com
https://tbpl.mozilla.org/php/getParsedLog.php?id=9803884&tree=Mozilla-Inbound
Rev3 Fedora 12x64 mozilla-inbound pgo test xpcshell on 2012-03-03 18:54:19

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | test failed (with xpcshell return code: 0), see following log:
TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | false == true - See following stack:

Comment 5

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a3b1c010b101