Closed Bug 731968 Opened 8 years ago Closed 8 years ago

intermittent toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | (some guid number) == 1234567890AB

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: mak, Assigned: mak)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

https://tbpl.mozilla.org/php/getParsedLog.php?id=9741720&tree=Mozilla-Inbound

TEST-INFO | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | Starting test_addLivemark_forceGuid_callback_succeeds

TEST-INFO | (xpcshell/head.js) | test 2 finished

TEST-PASS | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | [null : 292] true == true

TEST-UNEXPECTED-FAIL | /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js | 2oISlZ4_JHLa == 1234567890AB - See following stack:
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_throw :: line 462
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: _do_check_eq :: line 556
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/head.js :: do_check_eq :: line 577
JS frame :: /home/cltbld/talos-slave/test/build/xpcshell/tests/toolkit/components/places/tests/unit/test_mozIAsyncLivemarks.js :: <TOP_LEVEL> :: line 293
JS frame :: resource:///components/nsLivemarkService.js :: LS_addLivemark_ETAT :: line 422
and this actually happens because the guid is written asynchronously, so on creation we may callback before all writes are done, that is pretty bad for Sync.
Assignee: nobody → mak77
Attached patch patch v1.0Splinter Review
unfortunately I can't write a test here, the async write may happen at any time, even synchronously if the scheduler decides so.
Attachment #602216 - Flags: review?(dietrich)
Attachment #602216 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/mozilla-central/rev/a3b1c010b101
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.