732067 - Add a visual indicator for startup crashes in topcrasher list

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[Robert Kaiser]

As we now are gathering the info of what uptime slices a signature has at what percentage (for Signature Summary), we can identify crashes that are mostly startup with a rule like "<1min slice is over 50%" (which is what we'd propose to use for this right now).
It would be awesome to mark those signatures with a special icon in the topcrash list.

Comment 1

[Schalk Neethling [:espressive]]

Attachment: possible icon for startup

Comment 2

[Schalk Neethling [:espressive]]

[:kairo] If I use the getSummary function of signature summary and pass a signature, start date, end date and a report type of uptime, excluding the version I get a response like the following:

[{"category": "> 1 hour", "percentage": "0.53536", "report_count": 19540}, {"category": "15-60 min", "percentage": "0.26782", "report_count": 9775}, {"category": "5-15 min", "percentage": "0.12310", "report_count": 4493}, {"category": "1-5 min", "percentage": "0.07069", "report_count": 2580}, {"category": "< 1 min", "percentage": "0.00304", "report_count": 111}]

Do you want me to look whether:

1) there is a category of < 1min present
2) if there is, check whether the percentage for this category is greater then 50%
3) then mark this signature as a start-up crash if both the above conditions are met

Or is the above not going to work for the requirement here?

Comment 3

[Robert Kaiser]

(In reply to Schalk Neethling from comment #2)
> 1) there is a category of < 1min present
> 2) if there is, check whether the percentage for this category is greater
> then 50%
> 3) then mark this signature as a start-up crash if both the above conditions
> are met

Exactly that's what I have in mind.

Comment 4

[Schalk Neethling [:espressive]]

Sent pull request :: https://github.com/mozilla/socorro/pull/440

TEST CASE
----------

Head over to topcrasher, either by version or OS 

When the percentage of crashes for a specific signature in the category < 1 min exceeds 50% an icon, in the forms of a key, is added to the signature along side the other icons such as browser crash, hanged crash etc.

Comment 5

[Robert Kaiser]

Comment on attachment 605754 [details]
possible icon for startup

Umm, we use that for stuff with security keys in desktop software, I think. Also, not sure how a key relates to startup. Is there some rocket (pack) icon or so that we could use? I think that would present a better metaphor to startup.

Comment 6

[Schalk Neethling [:espressive]]

[:kairo] I will look for something better and add it.

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/26b486fad74c008c97f2a71bcb2160675696298b
Merge pull request #440 from ossreleasefeed/visual-indicator-startup-crashes-732067

adding startup crash icon fixes bug 732067

Comment 8

[Matt Brandt [:mbrandt]]

Attachment: qa - missing icon

Reopening: albeit I may be misunderstanding where the new icon should be present however I've not found an instance of it on stage -

Example:
https://crash-stats.allizom.org/report/list?range_value=7&range_unit=days&date=2012-03-23&signature=hang%20|%20WaitForSingleObjectEx%20|%20std%3A%3Alist%3Cgoogle_breakpad%3A%3AAppMemory%2C%20std%3A%3Aallocator%3Cgoogle_breakpad%3A%3AAppMemory%3E%20%3E%3A%3A_Insert_rv%3Cgoogle_breakpad%3A%3AAppMemory%3E%28std%3A%3A_List_const_iterator%3Cstd%3A%3A_List_val%3Cgoogle_breakpad%3A%3AAppMemory%2C%20std%3A%3Aallocator%3Cgoogle_breakpa...&version=Firefox%3A14.0a1

https://crash-stats.allizom.org/report/list?product=FennecAndroid&query_search=signature&query_type=contains&reason_type=contains&date=03%2F23%2F2012%2017%3A42%3A44&range_value=3&range_unit=weeks&hang_type=any&process_type=any&do_query=1&signature=java.lang.IllegalArgumentException%3A%20View%20not%20attached%20to%20window%20manager%20at%20android.view.WindowManagerImpl.findViewLocked%28WindowManagerImpl.java%29

Comment 9

[Matt Brandt [:mbrandt]]

thx :espressive - per an irc conversation :espressive & :jberkus are working on getting a fix in the works.

Comment 10

[[DEACTIVATED] Adrian Gaudebert]

This has been backed out of 3 and will come again in 4. Staging has been updated.

Comment 11

[Schalk Neethling [:espressive]]

Updated pull request :: https://github.com/mozilla/socorro/pull/472

Comment 12

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ae5aa56b5a33e9527b74404b4bad4cbc4050264e
multiply value returned by service to get percentage fixes bug 732067

https://github.com/mozilla/socorro/commit/e53d55f7d8f8b67a28dabcc3b267e95431bd5f01
Merge pull request #472 from ossreleasefeed/multiply-returned-value-fixes-bug732067

multiply value returned by service to get percentage fixes bug 732067

Comment 13

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/2d5b9858776939e9d9f2a473680a7f2019c8e27d
multiply value returned by service to get percentage fixes bug 732067

Comment 14

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage - the new startup crash icon is present as expected - spec in comment 0 -
Verified several Firefox signatures, FennecAndroid, and Fennec.

example:
https://crash-stats.allizom.org/topcrasher/byversion/FennecAndroid/13.0a1/7

https://crash-stats.allizom.org/report/list?range_value=7&range_unit=days&date=2012-04-01&signature=sqlite3_malloc&version=FennecAndroid%3A13.0a1