732078 - Look at whether we can avoid refreshing the icon cache every time we update

Status: NEW

(Firefox :: Installer, enhancement, P5)

Description

[Rain [:rain1] (inactive)]

Every time an update happens, in the post-update process we ask Windows to dump and refresh its icon cache. (The way to do this is by calling SHChangeNotify with SHCNE_ASSOCCHANGED at some point.) This causes all the icons on the desktop, pinned icons on the taskbar etc to momentarily flash while they're being refreshed.

We should look into whether we actually need to do this at every update.

Comment 1

[Robert Strong (they/them - no direct email)]

Agreed we should look at this further but bug 307181 does not depend on this so removing dependency.

Comment 2

[Rain [:rain1] (inactive)]

I couldn't find a meta bug for silent updates, heh.

Comment 3

[Jim Mathies [:jimm]]

wrong bug

Comment 4

[Jim Mathies [:jimm]]

http://hg.mozilla.org/mozilla-central/annotate/04caf36509e7/toolkit/mozapps/installer/windows/nsis/common.nsh#l4929

Comment 5

[u597032]

This isn't a bug. So could anyone mark this bug as resolved?

Comment 6

[Molly Howell (she/her) (mostly inactive)]

It's not a bug, but it is a valid enhancement request. It would be better if we could avoid having to do this. I suspect we can't, but I haven't really tried. So the bug stays open. Doesn't mean it has to get a high priority, though.