Closed Bug 732167 Opened 8 years ago Closed 8 years ago
eliminate duplicate headers in content/
Running: for f in $(find content -name '*.cpp'); do grep -B1 '#include' <(echo $f && grep '#include' $f | sort | uniq -d); done indicates a number of duplicate #includes. Some are necessary (atom lists and the like), but many are not. The duplicates should be removed.
I realize bz isn't a reviewer for everything in here (svg and xslt are the exceptions, maybe canvas?), but close enough?
Attachment #602085 - Flags: review?(bzbarsky)
Comment on attachment 602085 [details] [diff] [review] patch Drive-by review redirect
Attachment #602085 - Flags: review?(bzbarsky) → review?(mounir)
Attachment #602085 - Flags: review?(mounir) → review+
Updating patch; didn't apply cleanly. Hope it doesn't midair with other patches.
Refreshing again, just for good measure.
Whiteboard: [autoland-try:-b do -p all -u none -t none]
Whiteboard: [autoland-try:-b do -p all -u none -t none] → [autoland-in-queue]
Autoland Patchset: Patches: 606210 Branch: mozilla-central => try Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d9bc52f4e0ed Try run started, revision d9bc52f4e0ed. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed
Try run for d9bc52f4e0ed is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed Results (out of 14 total builds): success: 14 Builds (or logs if builds failed) available at: http://firstname.lastname@example.org
Target Milestone: --- → mozilla14
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.