The default bug view has changed. See this FAQ.

eliminate duplicate headers in content/

RESOLVED FIXED in mozilla14

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

unspecified
mozilla14
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Running:

for f in $(find content -name '*.cpp'); do grep -B1 '#include' <(echo $f && grep '#include' $f | sort | uniq -d); done

indicates a number of duplicate #includes.  Some are necessary (atom lists and the like), but many are not.  The duplicates should be removed.
(Assignee)

Comment 1

5 years ago
Created attachment 602085 [details] [diff] [review]
patch

I realize bz isn't a reviewer for everything in here (svg and xslt are the exceptions, maybe canvas?), but close enough?
Attachment #602085 - Flags: review?(bzbarsky)
Comment on attachment 602085 [details] [diff] [review]
patch

Drive-by review redirect
Attachment #602085 - Flags: review?(bzbarsky) → review?(mounir)
Attachment #602085 - Flags: review?(mounir) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 603358 [details] [diff] [review]
patch

Updating patch; didn't apply cleanly.  Hope it doesn't midair with other patches.
Assignee: nobody → nfroyd
Attachment #602085 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #603358 - Flags: review+
(Assignee)

Comment 4

5 years ago
Created attachment 606210 [details] [diff] [review]
patch

Refreshing again, just for good measure.
Attachment #603358 - Attachment is obsolete: true
Attachment #606210 - Flags: review+
(Assignee)

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u none -t none]

Updated

5 years ago
Whiteboard: [autoland-try:-b do -p all -u none -t none] → [autoland-in-queue]

Comment 5

5 years ago
Autoland Patchset:
	Patches: 606210
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d9bc52f4e0ed
Try run started, revision d9bc52f4e0ed. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed

Comment 6

5 years ago
Try run for d9bc52f4e0ed is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d9bc52f4e0ed

Updated

5 years ago
Whiteboard: [autoland-in-queue]
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/3228f7eeaeea
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/3228f7eeaeea
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.