Last Comment Bug 732167 - eliminate duplicate headers in content/
: eliminate duplicate headers in content/
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM: Core & HTML (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla14
Assigned To: Nathan Froyd [:froydnj]
:
: Andrew Overholt [:overholt]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-01 13:22 PST by Nathan Froyd [:froydnj]
Modified: 2012-03-16 06:31 PDT (History)
4 users (show)
ryanvm: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (27.34 KB, patch)
2012-03-01 13:24 PST, Nathan Froyd [:froydnj]
mounir: review+
Details | Diff | Splinter Review
patch (26.38 KB, patch)
2012-03-06 10:57 PST, Nathan Froyd [:froydnj]
nfroyd: review+
Details | Diff | Splinter Review
patch (26.35 KB, patch)
2012-03-15 07:46 PDT, Nathan Froyd [:froydnj]
nfroyd: review+
Details | Diff | Splinter Review

Description Nathan Froyd [:froydnj] 2012-03-01 13:22:52 PST
Running:

for f in $(find content -name '*.cpp'); do grep -B1 '#include' <(echo $f && grep '#include' $f | sort | uniq -d); done

indicates a number of duplicate #includes.  Some are necessary (atom lists and the like), but many are not.  The duplicates should be removed.
Comment 1 Nathan Froyd [:froydnj] 2012-03-01 13:24:54 PST
Created attachment 602085 [details] [diff] [review]
patch

I realize bz isn't a reviewer for everything in here (svg and xslt are the exceptions, maybe canvas?), but close enough?
Comment 2 :Ms2ger (⌚ UTC+1/+2) 2012-03-01 13:42:07 PST
Comment on attachment 602085 [details] [diff] [review]
patch

Drive-by review redirect
Comment 3 Nathan Froyd [:froydnj] 2012-03-06 10:57:13 PST
Created attachment 603358 [details] [diff] [review]
patch

Updating patch; didn't apply cleanly.  Hope it doesn't midair with other patches.
Comment 4 Nathan Froyd [:froydnj] 2012-03-15 07:46:35 PDT
Created attachment 606210 [details] [diff] [review]
patch

Refreshing again, just for good measure.
Comment 5 Mozilla RelEng Bot 2012-03-15 07:51:15 PDT
Autoland Patchset:
	Patches: 606210
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d9bc52f4e0ed
Try run started, revision d9bc52f4e0ed. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed
Comment 6 Mozilla RelEng Bot 2012-03-15 12:32:06 PDT
Try run for d9bc52f4e0ed is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d9bc52f4e0ed
Comment 7 Ryan VanderMeulen [:RyanVM] 2012-03-15 17:14:08 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/3228f7eeaeea
Comment 8 Marco Bonardo [::mak] 2012-03-16 06:31:27 PDT
https://hg.mozilla.org/mozilla-central/rev/3228f7eeaeea

Note You need to log in before you can comment on or make changes to this bug.