Closed Bug 732167 Opened 8 years ago Closed 8 years ago

eliminate duplicate headers in content/

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla14

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file, 2 obsolete files)

Running:

for f in $(find content -name '*.cpp'); do grep -B1 '#include' <(echo $f && grep '#include' $f | sort | uniq -d); done

indicates a number of duplicate #includes.  Some are necessary (atom lists and the like), but many are not.  The duplicates should be removed.
Attached patch patch (obsolete) — Splinter Review
I realize bz isn't a reviewer for everything in here (svg and xslt are the exceptions, maybe canvas?), but close enough?
Attachment #602085 - Flags: review?(bzbarsky)
Comment on attachment 602085 [details] [diff] [review]
patch

Drive-by review redirect
Attachment #602085 - Flags: review?(bzbarsky) → review?(mounir)
Attachment #602085 - Flags: review?(mounir) → review+
Attached patch patch (obsolete) — Splinter Review
Updating patch; didn't apply cleanly.  Hope it doesn't midair with other patches.
Assignee: nobody → nfroyd
Attachment #602085 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #603358 - Flags: review+
Attached patch patchSplinter Review
Refreshing again, just for good measure.
Attachment #603358 - Attachment is obsolete: true
Attachment #606210 - Flags: review+
Whiteboard: [autoland-try:-b do -p all -u none -t none]
Whiteboard: [autoland-try:-b do -p all -u none -t none] → [autoland-in-queue]
Autoland Patchset:
	Patches: 606210
	Branch: mozilla-central => try
	Destination: http://hg.mozilla.org/try/pushloghtml?changeset=d9bc52f4e0ed
Try run started, revision d9bc52f4e0ed. To cancel or monitor the job, see: https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed
Try run for d9bc52f4e0ed is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=d9bc52f4e0ed
Results (out of 14 total builds):
    success: 14
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/autolanduser@mozilla.com-d9bc52f4e0ed
Whiteboard: [autoland-in-queue]
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/3228f7eeaeea
Flags: in-testsuite-
Keywords: checkin-needed
Target Milestone: --- → mozilla14
https://hg.mozilla.org/mozilla-central/rev/3228f7eeaeea
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.