Closed Bug 732193 Opened 13 years ago Closed 13 years ago

handle components with slashes in their names

Categories

(Developer Services :: Mercurial: bzexport, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: sfink, Assigned: sfink)

Details

Attachments

(1 file)

Components can legitimately contain the '/' character. Don't interpret --component "foo/bar" as product=foo component=bar if it is an exact match.
Comment on attachment 602113 [details] [diff] [review]
Don't interpret --component "foo/bar" as product=foo component=bar if it is an exact match

>+    if component is not None and product is None:

Is there a reason this can't be |if component and not product|?
Attachment #602113 - Flags: review?(josh) → review+
(In reply to Josh Matthews [:jdm] from comment #2)
> Comment on attachment 602113 [details] [diff] [review]
> Don't interpret --component "foo/bar" as product=foo component=bar if it is
> an exact match
> 
> >+    if component is not None and product is None:
> 
> Is there a reason this can't be |if component and not product|?

Silly paranoia. What if you had a component named '0'? Think of the children!

Oh, wait. This is Python, not Perl. Never mind; fixed.

http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/9ee8ce05c83a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Product: Other Applications → Developer Services
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: