732193 - handle components with slashes in their names

Status: RESOLVED FIXED

(Developer Services :: Mercurial: bzexport, defect)

Description

[Steve Fink [:sfink] [:s:]]

Components can legitimately contain the '/' character. Don't interpret --component "foo/bar" as product=foo component=bar if it is an exact match.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Don't interpret --component "foo/bar" as product=foo component=bar if it is an exact match

Comment 2

[Josh Matthews [:jdm]]

Comment on attachment 602113 [details] [diff] [review]
Don't interpret --component "foo/bar" as product=foo component=bar if it is an exact match

>+    if component is not None and product is None:

Is there a reason this can't be |if component and not product|?

Comment 3

[Steve Fink [:sfink] [:s:]]

(In reply to Josh Matthews [:jdm] from comment #2)
> Comment on attachment 602113 [details] [diff] [review]
> Don't interpret --component "foo/bar" as product=foo component=bar if it is
> an exact match
> 
> >+    if component is not None and product is None:
> 
> Is there a reason this can't be |if component and not product|?

Silly paranoia. What if you had a component named '0'? Think of the children!

Oh, wait. This is Python, not Perl. Never mind; fixed.

http://hg.mozilla.org/users/tmielczarek_mozilla.com/bzexport/rev/9ee8ce05c83a