Closed
Bug 732292
Opened 13 years ago
Closed 13 years ago
use XPCOMUtils.defineLazyModuleGetter in sessionstore
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 14
People
(Reporter: zpao, Assigned: zpao)
Details
Attachments
(1 file)
|
1.87 KB,
patch
|
dietrich
:
review+
|
Details | Diff | Splinter Review |
Turns out we have defineLazyModuleGetter now, so we can convert the handful of imports that session restore is doing to use it.
If you're interested in taking this, here are some places to start looking:
https://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/nsSessionStore.js
https://mxr.mozilla.org/mozilla-central/source/js/xpconnect/loader/XPCOMUtils.jsm#250
|
||
Comment 1•13 years ago
|
||
beware of bug 732385
|
Assignee | |
Comment 2•13 years ago
|
||
(In reply to Marco Bonardo [:mak] from comment #1)
> beware of bug 732385
Thanks for the heads up, but session restore should be fine, we're only importing 1 symbol anyway (at least for the ones we already have wrapped in lazy getters)
|
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → paul
Attachment #614930 -
Flags: review?(dietrich)
|
||
Updated•13 years ago
|
Attachment #614930 -
Flags: review?(dietrich) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
Whiteboard: [good first bug][mentor=zpao][lang=js]
Target Milestone: --- → Firefox 14
|
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•