Closed Bug 732292 Opened 9 years ago Closed 9 years ago

use XPCOMUtils.defineLazyModuleGetter in sessionstore

Categories

(Firefox :: Session Restore, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 14

People

(Reporter: zpao, Assigned: zpao)

Details

Attachments

(1 file)

Turns out we have defineLazyModuleGetter now, so we can convert the handful of imports that session restore is doing to use it.

If you're interested in taking this, here are some places to start looking:
https://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/nsSessionStore.js
https://mxr.mozilla.org/mozilla-central/source/js/xpconnect/loader/XPCOMUtils.jsm#250
beware of bug 732385
(In reply to Marco Bonardo [:mak] from comment #1)
> beware of bug 732385

Thanks for the heads up, but session restore should be fine, we're only importing 1 symbol anyway (at least for the ones we already have wrapped in lazy getters)
Attached patch Patch v0.1Splinter Review
Assignee: nobody → paul
Attachment #614930 - Flags: review?(dietrich)
Attachment #614930 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/26439e0c3679
Whiteboard: [good first bug][mentor=zpao][lang=js]
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/26439e0c3679
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.