The default bug view has changed. See this FAQ.

use XPCOMUtils.defineLazyModuleGetter in sessionstore

RESOLVED FIXED in Firefox 14

Status

()

Firefox
Session Restore
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: zpao, Assigned: zpao)

Tracking

Trunk
Firefox 14
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Turns out we have defineLazyModuleGetter now, so we can convert the handful of imports that session restore is doing to use it.

If you're interested in taking this, here are some places to start looking:
https://mxr.mozilla.org/mozilla-central/source/browser/components/sessionstore/src/nsSessionStore.js
https://mxr.mozilla.org/mozilla-central/source/js/xpconnect/loader/XPCOMUtils.jsm#250
beware of bug 732385
(In reply to Marco Bonardo [:mak] from comment #1)
> beware of bug 732385

Thanks for the heads up, but session restore should be fine, we're only importing 1 symbol anyway (at least for the ones we already have wrapped in lazy getters)
Created attachment 614930 [details] [diff] [review]
Patch v0.1
Assignee: nobody → paul
Attachment #614930 - Flags: review?(dietrich)
Attachment #614930 - Flags: review?(dietrich) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/26439e0c3679
Whiteboard: [good first bug][mentor=zpao][lang=js]
Target Milestone: --- → Firefox 14
https://hg.mozilla.org/mozilla-central/rev/26439e0c3679
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.