nsInputStreamChannel needs to forward itself as the request in progress events

RESOLVED FIXED in mozilla0.9.1

Status

()

defect
RESOLVED FIXED
19 years ago
17 years ago

People

(Reporter: darin.moz, Assigned: rpotts)

Tracking

Trunk
mozilla0.9.1
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Reporter

Description

19 years ago
nsInputStreamChannel needs to forward itself as the request in progress events
(eg. nsHTTPChannel implements nsIProgressEventSink on behalf of the socket
transport).

Updated

19 years ago
Blocks: 64833
Keywords: mozilla0.9
Reporter

Updated

19 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9
Reporter

Updated

19 years ago
Keywords: nsbeta1
Reporter

Comment 1

19 years ago
Reporter

Comment 2

19 years ago
dougt, rpotts: can you review this patch?  thx!
Reporter

Updated

19 years ago
Keywords: patch
it looks fine. sr=dougt.
Assignee

Comment 4

19 years ago
looks good... r=rpotts

-- rick
Reporter

Comment 5

19 years ago
fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Assignee

Comment 6

18 years ago
Guess what...  the patch was wrong :-(

i'm reopening this one, so I cna make sure that it gets fixed...
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee

Comment 7

18 years ago
-> rpotts...  I want to make sure that this gets in for 0.9.1
why is it wrong? / what did it break?
Assignee

Comment 9

18 years ago
Assignee

Comment 10

18 years ago
I've just attached a new patch to the old patch which correctly passes the
nsInputStreamChannel out as the request - rather than the underlying transport
request...

When the transport request was passed out, the progress info would be ignored by
the DocLoader because it did not recognize the request - ie. an OnStartRequest()
for the request had not been fired (only the OnProgress...)

Reporter

Comment 11

18 years ago
r/sr=darin
Assignee

Comment 12

18 years ago
I'll check this in asw soon as I get an a= and the tree opens :-)

Comment 13

18 years ago
r=valeski
Assignee

Comment 14

18 years ago
blah...
Assignee: darin → rpotts
Status: REOPENED → NEW
Keywords: mozilla0.9mozilla0.9.1
Target Milestone: mozilla0.9 → mozilla0.9.1
a= asa@mozilla.org for checkin to 0.9.1 (on behalf of drivers).
Assignee

Comment 16

18 years ago
fix checked in...
Status: NEW → RESOLVED
Closed: 19 years ago18 years ago
Resolution: --- → FIXED

Updated

18 years ago
No longer blocks: 64833

Updated

17 years ago
QA Contact: tever → benc
You need to log in before you can comment on or make changes to this bug.