If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Port |Bug 606681 - deleteTabValue should not throw an exception| to SeaMonkey

RESOLVED FIXED in seamonkey2.10

Status

SeaMonkey
Session Restore
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Misak Khachatryan, Assigned: Misak Khachatryan)

Tracking

SeaMonkey 2.9 Branch
seamonkey2.10

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

4.30 KB, patch
neil@parkwaycc.co.uk
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
Created attachment 602284 [details] [diff] [review]
patch

From parent bug:

I see no reason for deleteTabValue API to throw an exception when the key does not exist. It needs to be fixed, although we can use setTabValue(aTab, aKey, "") instead.

Reproducible: Always

Steps to Reproduce:
var ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
ss.deleteTabValue(gBrowser.mCurrentTab, "unread");
ss.deleteTabValue(gBrowser.mCurrentTab, "unread");
Attachment #602284 - Flags: review?(neil)

Comment 1

6 years ago
Comment on attachment 602284 [details] [diff] [review]
patch

>   // test deleting 
>+
Nit: unnecessary.
Attachment #602284 - Flags: review?(neil) → review+
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/comm-central/rev/1ec9702698fb
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.10
Version: Trunk → SeaMonkey 2.9 Branch
You need to log in before you can comment on or make changes to this bug.