Closed Bug 732345 Opened 11 years ago Closed 11 years ago

Port |Bug 606681 - deleteTabValue should not throw an exception| to SeaMonkey

Categories

(SeaMonkey :: Session Restore, defect)

Product:
SeaMonkey
Component:
Session Restore
Version:
SeaMonkey 2.9 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.10

People

(Reporter: misak.bugzilla, Assigned: misak.bugzilla)

References

Details

Attachments

(1 file)

patch
4.30 KB, patch
neil
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
From parent bug:

I see no reason for deleteTabValue API to throw an exception when the key does not exist. It needs to be fixed, although we can use setTabValue(aTab, aKey, "") instead.

Reproducible: Always

Steps to Reproduce:
var ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
ss.deleteTabValue(gBrowser.mCurrentTab, "unread");
ss.deleteTabValue(gBrowser.mCurrentTab, "unread");
Attachment #602284 - Flags: review?(neil)
Comment on attachment 602284 [details] [diff] [review]
patch

>   // test deleting 
>+
Nit: unnecessary.
Attachment #602284 - Flags: review?(neil) → review+
http://hg.mozilla.org/comm-central/rev/1ec9702698fb
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.10
Version: Trunk → SeaMonkey 2.9 Branch
You need to log in before you can comment on or make changes to this bug.