Closed
Bug 732345
Opened 13 years ago
Closed 13 years ago
Port |Bug 606681 - deleteTabValue should not throw an exception| to SeaMonkey
Categories
(SeaMonkey :: Session Restore, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.10
People
(Reporter: misak.bugzilla, Assigned: misak.bugzilla)
References
Details
Attachments
(1 file)
|
4.30 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
From parent bug:
I see no reason for deleteTabValue API to throw an exception when the key does not exist. It needs to be fixed, although we can use setTabValue(aTab, aKey, "") instead.
Reproducible: Always
Steps to Reproduce:
var ss = Cc["@mozilla.org/browser/sessionstore;1"].getService(Ci.nsISessionStore);
ss.deleteTabValue(gBrowser.mCurrentTab, "unread");
ss.deleteTabValue(gBrowser.mCurrentTab, "unread");
Attachment #602284 -
Flags: review?(neil)
|
||
Comment 1•13 years ago
|
||
Comment on attachment 602284 [details] [diff] [review]
patch
> // test deleting
>+
Nit: unnecessary.
Attachment #602284 -
Flags: review?(neil) → review+
|
Assignee | |
Comment 2•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.10
Version: Trunk → SeaMonkey 2.9 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•