Closed Bug 732607 Opened 8 years ago Closed 8 years ago

Make nsTArray assertions fatal

Categories

(Core :: XPCOM, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla13

People

(Reporter: jruderman, Assigned: jruderman)

Details

Attachments

(1 file)

Attached patch patch (diff -w)Splinter Review
Many of the assertions in nsTArray are trying to protect against buffer overflows, so I think they should be fatal.

Changed:
* All NS_ASSERTION and NS_PRECONDITION

Not changed:
* All NS_ABORT_IF_FALSE
* NS_ERROR("Attempting to allocate excessively large array");
Attachment #602513 - Flags: review?(bzbarsky)
Comment on attachment 602513 [details] [diff] [review]
patch (diff -w)

r=me
Attachment #602513 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/c51dbd19871b
Target Milestone: --- → mozilla13
https://hg.mozilla.org/mozilla-central/rev/c51dbd19871b
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.