Closed Bug 732615 Opened 8 years ago Closed 8 years ago

Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit

Categories

(Toolkit :: Add-ons Manager, enhancement, P4)

enhancement

Tracking

()

VERIFIED FIXED
mozilla13

People

(Reporter: sgautherie, Assigned: sgautherie)

References

Details

Attachments

(2 files)

browser_checkAddonCompatibility.js was created and added to SeaMonkey in bug 728651.
It's a "user level" complement to "developer level" browser_bug557956.js.

I believe any application that bundle add-ons should want this test too.
Succeeded as
https://tbpl.mozilla.org/?tree=Try&rev=f54878d5937e
+
https://tbpl.mozilla.org/php/getParsedLog.php?id=9784388&tree=Try&full=1
Full Log - Rev3 Fedora 12x64 try debug test mochitest-other on 2012-03-02 14:25:51 PST
{
TEST-START | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_checkAddonCompatibility.js
[...] | Strict compatibility should be enabled
[...] | Default 13.0a1 should be compatible
[...] | Mochitest 1.0 should be compatible
[...] | Special Powers 2010.07.23 should be compatible
[...] | WorkerTest 2011.10.10 should be compatible
[...] | WorkerTestBootstrap 2011.10.10 should be compatible
INFO TEST-END | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_checkAddonCompatibility.js | finished in 70ms
}
Attachment #602525 - Flags: review?(bmcbride)
Comment on attachment 602525 [details] [diff] [review]
(Av1-TK) Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit
[Checked in: See comment 2]

Review of attachment 602525 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/mozapps/extensions/test/browser/browser_checkAddonCompatibility.js
@@ +9,5 @@
> +
> +  Services.prefs.setBoolPref(PREF_STRICT_COMPAT, true);
> +  ok(AddonManager.strictCompatibility, "Strict compatibility should be enabled");
> +
> +  AddonManager.getAllAddons(function gAACallback(aAddons) {

The output of this could get noisy, since we're making various additional things into addon types (eg, search-engine). Still, it's nothing that should ever be incompatible, so I guess that output noise is ok.

@@ +21,5 @@
> +      // Ignore plugins.
> +      if (a.type == "plugin")
> +        return;
> +
> +      ok(a.isCompatible, a.name + " " + a.version + " should be compatible");

Would be useful to include a.type in this output, otherwise it could be a pain to figure out failures.
Attachment #602525 - Flags: review?(bmcbride) → review+
Comment on attachment 602525 [details] [diff] [review]
(Av1-TK) Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit
[Checked in: See comment 2]

https://hg.mozilla.org/mozilla-central/rev/5458ba880b4f
Av1-TK, with comment 2 suggestion(s).
Attachment #602525 - Attachment description: (Av1-TK) Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit → (Av1-TK) Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit [Checked in: See comment 2]
Attachment #602607 - Flags: review?(jh) → review+
(In reply to Serge Gautherie (:sgautherie) from comment #3)
> https://hg.mozilla.org/mozilla-central/rev/5458ba880b4f

https://tbpl.mozilla.org/php/getParsedLog.php?id=9797807&tree=Firefox&full=1
Rev3 Fedora 12 mozilla-central debug test mochitest-other on 2012-03-03 06:30:54 PST for push 5458ba880b4f
{
TEST-START | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_checkAddonCompatibility.js
TEST-PASS | [...] | Strict compatibility should be enabled
TEST-PASS | [...] | extension Mochitest 1.0 should be compatible
TEST-PASS | [...] | extension Special Powers 2010.07.23 should be compatible
TEST-PASS | [...] | extension WorkerTest 2011.10.10 should be compatible
TEST-PASS | [...] | extension WorkerTestBootstrap 2011.10.10 should be compatible
TEST-PASS | [...] | theme Default 13.0a1 should be compatible
INFO TEST-END | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_checkAddonCompatibility.js | finished in 84ms
}

V.Fixed wrt TK part (only).
Comment on attachment 602607 [details] [diff] [review]
(Bv1-SM) Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit
[Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/c620ba21d50f
Attachment #602607 - Attachment description: (Bv1-SM) Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit → (Bv1-SM) Move browser_checkAddonCompatibility.js test from SeaMonkey to Toolkit [Checked in: Comment 6]
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
V.Fixed, per comment 5 (+ 6).
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.