732641 - Implement @retriable decorator to simplify usage of retry()

Status: RESOLVED FIXED

(Release Engineering :: General, enhancement, P3)

Description

[Rail Aliiev [:rail]]

Attachment: retriable

Sometimes it's hard to read the code wrapped with retry() function, especially if you want to pass just one parameter:

retry(func, args=(foo,), retry_exceptions=(MyError,), ...)

Sometimes it's simpler to make a function retriable always and call it directly:

@retriable(retry_exceptions=(MyError,))
def func(foo):
    ...

func(foo)

Initial implementation with tests attached.

Comment 1

[Rail Aliiev [:rail]]

Attachment: retriable

It turned out that I prepared the patch against an old tools repo. :/

Refreshed patch sleeptime explicitly set to 0. No changes in retry.py.

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 603342 [details] [diff] [review]
retriable

http://hg.mozilla.org/build/tools/rev/14542113c240

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 603342 [details] [diff] [review]
retriable

Python 2.5 bustage fix
http://hg.mozilla.org/build/tools/rev/78c8caa0cd5b

Comment 4

[Rail Aliiev [:rail]]

Python 2.5 failed:

Traceback (most recent call last):
  File "e:/builds/moz2_slave/m-in-w32/tools/buildfarm/utils/retry.py", line 16, in <module>
    from util.retry import retry
  File "e:/builds/moz2_slave/m-in-w32/tools/buildfarm/utils\../../lib/python\util\retry.py", line 57
    return retry(func, *retry_args, args=args, kwargs=kwargs,
                                       ^
SyntaxError: invalid syntax

Ben backed out the patches.

Comment 5

[Rail Aliiev [:rail]]

Attachment: retriable

I changed the order of arguments being passed to retry() to be compatible with python 2.5 (1 liner change).

Unit tests have passed python 2.6.5 (linux build slave), 2.7.2 (my laptop) and 2.5 (Windows build slave).

Comment 6

[Rail Aliiev [:rail]]

Comment on attachment 607144 [details] [diff] [review]
retriable

http://hg.mozilla.org/build/tools/rev/deb5c98730d7

Comment 7

[Rail Aliiev [:rail]]

Looks like it worked properly this time.