Closed
Bug 732675
Opened 12 years ago
Closed 12 years ago
IonMonkey: scratch register gets overwritten on ARM
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: mjrosenb, Unassigned)
Details
Attachments
(1 file)
3.85 KB,
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
If you attempt to store an immediate into a large offset from a base register, we attempt to use the scratch register to hold both the calculated offset, as well as the immediate. This currently results in a bogus value being written into the correct location, rather than a sane value being written into a bogus location.
Reporter | ||
Comment 1•12 years ago
|
||
The inevitable has happened, and I'm giving in and taking a second scratch register for ARM. the previously unused link register will become the second scratch register. Previously, it was only used in one spot, but I'd missed a whole load of cases where two different values need to be in a scratch register at the same time
Attachment #602875 -
Flags: review?(dvander)
Updated•12 years ago
|
Attachment #602875 -
Flags: review?(dvander) → review+
Reporter | ||
Comment 2•12 years ago
|
||
landed: http://hg.mozilla.org/projects/ionmonkey/rev/8979dfc0ddf2
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•