732745 - (Venkman_0.9.89) Release Venkman 0.9.89

Status: RESOLVED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, defect)

Description

[Serge Gautherie (:sgautherie)]

0.9.88.2 was (not) tagged 11 months ago.
http://hg.mozilla.org/venkman/rev/5e7659a617fa

A lot has happened since then.
SeaMonkey builds off of
http://hg.mozilla.org/venkman/rev/a38583d7164a
and should switch to
http://hg.mozilla.org/venkman/rev/65ad515ebba6

Time to actually tag 0.9.88.3?

Comment 1

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #0)
> Time to actually tag 0.9.88.3?

Or 0.9.89...

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Release Venkman 0.9.89, Update (missed) locale to 0.9.88 [Checked in: Comment 4]

I think
http://hg.mozilla.org/venkman/rev/148fe7bca62e
"Bug 418426 - JavaScript Debugger (Venkman) ignores breakpoints"
is worth a 0.9.89 release.

Last locale addition was
http://hg.mozilla.org/venkman/rev/289e582190e8
"Bug 576869 - Fix Venkman for the new component registration world"
which was released in 0.9.88.
(Ftr, there were 2-3 minor changes after that, but I assume they don't need to be required.)

Comment 3

[:Gijs (he/him)]

Comment on attachment 602863 [details] [diff] [review]
(Av1) Release Venkman 0.9.89, Update (missed) locale to 0.9.88
[Checked in: Comment 4]

r=me

I'll try to get a release uploaded to AMO when I've left work.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 602863 [details] [diff] [review]
(Av1) Release Venkman 0.9.89, Update (missed) locale to 0.9.88
[Checked in: Comment 4]

https://hg.mozilla.org/venkman/rev/d6a96f4eb38a


(In reply to Gijs Kruitbosch from comment #3)
> I'll try to get a release uploaded to AMO when I've left work.

I let you resolve this bug when you're done.

Comment 5

[Serge Gautherie (:sgautherie)]

(In reply to Serge Gautherie (:sgautherie) from comment #4)
> I let you resolve this bug when you're done.

Please, tag(/branch) the release revision, so it's easier to pull from it.

Comment 6

[Jens Hatlak (:InvisibleSmiley)]

So did I miss anything or is the summary actually wrong now? [Won't change it myself since I'm genuinely confused.]

Comment 7

[:Gijs (he/him)]

(In reply to Jens Hatlak (:InvisibleSmiley) from comment #6)
> So did I miss anything or is the summary actually wrong now? [Won't change
> it myself since I'm genuinely confused.]

Yes.

Comment 8

[:Gijs (he/him)]

Submitted to AMO, tagged.

Comment 9

[Serge Gautherie (:sgautherie)]

Ftr,
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1332317963.1332323931.19075.gz
WINNT 5.2 comm-central-trunk debug test mochitest-other on 2012/03/21 01:19:23
{
TEST-PASS | chrome://mochitests/content/browser/toolkit/mozapps/extensions/test/browser/browser_checkAddonCompatibility.js | extension JavaScript Debugger 0.9.89 should be compatible
}
:-)

Comment 10

[Ian Neal]

Comment on attachment 602863 [details] [diff] [review]
(Av1) Release Venkman 0.9.89, Update (missed) locale to 0.9.88
[Checked in: Comment 4]

>+++ b/locales/en-US/chrome/venkman.properties
>+msg.locale.version = 0.9.88

>+++ b/resources/content/venkman-static.js
>+const __vnk_requiredLocale = "0.9.88";

>+++ b/version.txt
>+0.9.89

Shouldn't these all match?

Comment 11

[:Gijs (he/him)]

(In reply to Ian Neal from comment #10)
> Comment on attachment 602863 [details] [diff] [review]
> (Av1) Release Venkman 0.9.89, Update (missed) locale to 0.9.88
> [Checked in: Comment 4]
> 
> >+++ b/locales/en-US/chrome/venkman.properties
> >+msg.locale.version = 0.9.88
> 
> >+++ b/resources/content/venkman-static.js
> >+const __vnk_requiredLocale = "0.9.88";
> 
> >+++ b/version.txt
> >+0.9.89
> 
> Shouldn't these all match?

No. version.txt has the XPI version. The other ones are the version of the locale required. That is only increased if there are string changes; this way localizers don't have to release dummy updates with no changes.